From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 06460C348 for ; Fri, 5 Jun 2015 23:04:39 +0200 (CEST) Received: by wiwd19 with SMTP id d19so32615985wiw.0 for ; Fri, 05 Jun 2015 14:04:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=b5rWYjU0aozdAp2sqWlvVCbwnhPoCVNf9UebMzbn3co=; b=ScuPDhUQMV0fZX82JYS5TkBMdWNFcjvYHNjtAFMLw6A8/vKwnTXbrsUNEmeBKyZGEJ oDyGSL4Kdouqv3zRJMjw+wF7pHpKdmFc/QcvsTtLDc1rXDFZLyNxtCO8r/vlEiyF0AS1 zW8CuV23C1ZUkoVzt++2s8jpLQ4CwA6xQPgLvvCz22fHRybkpCqrMFlBW7KtJglCFVbJ QOAzwN0O4uL1TPKGVLHA3kLmaFM2xpR14FVH5Iv3qun7QWLPwn8HZglCXGHROEIYd79W NX5kDwhlfzMcuDlRN95V/XirR+q1cC7sjFhbJmKdQ1tfBgb21Dp2bm1y2sAxtkWKrUxD ciwQ== X-Gm-Message-State: ALoCoQkNnbnQ3oze2HAkFB6d50jQ7vLpPe+07s6OlOjut6wqDNB7+AO+1m4QGWgENs7tBe0dZbPw X-Received: by 10.194.71.105 with SMTP id t9mr9485559wju.128.1433538278877; Fri, 05 Jun 2015 14:04:38 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id b7sm12267657wjx.47.2015.06.05.14.04.37 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jun 2015 14:04:38 -0700 (PDT) From: Thomas Monjalon To: "Andrew Harvey (agh)" Date: Fri, 05 Jun 2015 23:03:44 +0200 Message-ID: <1719417.vraBA1o1Y8@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <1432927612-12244-1-git-send-email-liang-min.wang@intel.com> <20150605124748.GA6760@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, "Wang, Liang-min" Subject: Re: [dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jun 2015 21:04:39 -0000 2015-06-05 17:24, Andrew Harvey: > On 6/5/15, 5:47 AM, "Bruce Richardson" wrote: > >> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > >> > That's why we need to understand what we (or you) are missing. > >> > Maybe that it would be clearer with some code examples (which would > >> > go in the lib documentation if any). > >> > > >> > Thanks > > > >How about doing this work as a sample application initially, to > >demonstrate how > >an application written using ethtool APIs could be shimmed to use DPDK > >underneath. > >The ethtool to dpdk mapping could be contained in a single header file > >(or header > >and c file) inside the sample app. This would allow easy re-use of the > >shim > >layer, while at the same time not making it part of the core DPDK > >libraries. > > > >Regards, > >/Bruce > > This would appear to be the most pragmatic way forward. It would allow > others to see more of the code and judge its value for themselves. I have > no issues with this approach if others agree. Since the beginning of this thread, a doc is requested (many times) to show the benefit of integrating such a layer. If you prefer coding a full example, it would probably also be fine.