From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id 4BF88C40C for ; Fri, 24 Jul 2015 14:41:49 +0200 (CEST) Received: by wicgb10 with SMTP id gb10so27163036wic.1 for ; Fri, 24 Jul 2015 05:41:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=JBr5vjTYx7PNMf2LviClSlq2QZ9FCFsMomfnKdlI1q0=; b=Nd9QaW9pbXMpiricsNfrmNjPfLqgGSf2SUgsksFTEViyK3cngZ9bxJ0n2ZiZFn2Lwd dQGUklLD3O7mAFlWpU8EzXtqSzHSR1V3U3n2BzC06iQqW5BaKJ3q+73qebUBs5LOansr aFNpvA+cc82SJOFj0XislpbMjuGZO/ndt6QHU6LoshYpMzUHvQo1Z4jxAgGG4rpRbrtx NaeQ+pZs1b36xY+hqzSSX8ZhZsE/EK0Sl87jYLtIveq9LD1Jm4N2X+XSF8BYUcXz50gp tuF+0j+mU0mwZC6JhNsfkCCUnzSkBkl0j7oDSxwTHy/xX1vIuzp5dAZ71apLqONHVTFn PqEw== X-Gm-Message-State: ALoCoQkSGFS/G7J73e96MNFTvczsjzM9a4HwRiZlANZi2pjE8HqUWtikU3EQd9G/rqOAbuGiNFsy X-Received: by 10.194.243.230 with SMTP id xb6mr26462572wjc.13.1437741709043; Fri, 24 Jul 2015 05:41:49 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id fs8sm12495009wjb.7.2015.07.24.05.41.47 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Jul 2015 05:41:48 -0700 (PDT) From: Thomas Monjalon To: "Ananyev, Konstantin" Date: Fri, 24 Jul 2015 14:40:34 +0200 Message-ID: <1721895.b8uNhSIC4P@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <2601191342CEEE43887BDE71AB97725836A6723D@irsmsx105.ger.corp.intel.com> References: <1437589735-30041-1-git-send-email-konstantin.ananyev@intel.com> <2058063.jaPb6Gx79p@xps13> <2601191342CEEE43887BDE71AB97725836A6723D@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCHv4 1/5] ethdev: add new API to retrieve RX/TX queue information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2015 12:41:49 -0000 2015-07-24 10:50, Ananyev, Konstantin: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2015-07-24 09:15, Ananyev, Konstantin: > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > 2015-07-22 19:28, Konstantin Ananyev: > > > > > +struct rte_eth_rxq_info { > > > > > + struct rte_mempool *mp; /**< mempool used by that queue. */ > > > > > + struct rte_eth_rxconf conf; /**< queue config parameters. */ > > > > > + uint8_t scattered_rx; /**< scattered packets RX supported. */ > > > > > + uint16_t nb_desc; /**< configured number of RXDs. */ > > > > > > > > Shouldn't we move nb_desc in rte_eth_rxconf? > > > > So rte_eth_rx_queue_setup() would have less parameters. > > > > > > I thought about that too, but it seems more drawbacks then pluses with that idea: > > > 1. Right now it is possible to call rte_eth_rx_queue_setup(..., rx_conf=NULL, ...); > > > In that case rte_eth_rx_queue_setup()will use default for that device rx_conf. > > > If we'll move mempool into rxconf, will break that ability. > > > 2. A bit unclear what mempool should be returned as default_rxconf by rte_eth_dev_info_get(). > > > Should it be just NULL. > > > > I was only suggesting to move nb_desc, not mempool. > > Ah, sorry didn't read it properly first time. > Yes, I think it makes sense to move nb_desc into rxconf, though that means ABI breakage, > and that patch would definitely not make into 2.1. You can avoid ABI breakage by using the compat macros and/or NEXT_ABI. But it shouldn't go into 2.1 as the API shouldn't be changed after RC1.