From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id E5C7A5A8C for ; Mon, 30 Mar 2015 23:30:21 +0200 (CEST) Received: by wgbgs4 with SMTP id gs4so98480539wgb.0 for ; Mon, 30 Mar 2015 14:30:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=4LRuqVDmPQtaeo9qIHoRF/sm1devSijZvZ4CeBrwrCM=; b=aMVD84XQmVE5sO5kSe63K4dEv0xG8udTFbJX4DFFgaGi2wlYOYlriwTh1StUzbp1Kz 1nYmVNcN7J3IWywBIeXFYB77XSddeW5PVKuoyiUXSuZZ8WI6nR3m+JcmZaoqK4YoC0TB ArzG3CMw2unTV4LSMA0tGSKaViAUQ7c+igWFmxgCKvquRqbgfqX4DPMKIXyikxs9kQFS nmElJ/aPDoOdtGelSf5ez/czwu3i4OOZ5W/wT/0bf8mqIcDatUh9wLCxgjQNvwABAl0L xb/KaNao5zdW6cq3EhBCJGDbB3dsEVTBTT4wVY00KVgwdTJ/V+6EILsRTklU33kzPsjR n2Ew== X-Gm-Message-State: ALoCoQmX+uxOfDC1HOOiwOydNyT9ZEM0E+fhSUfNX78975w5o4EONTyHLluEuHU7de3GT3ay8L4Z X-Received: by 10.180.83.227 with SMTP id t3mr8650781wiy.90.1427751021799; Mon, 30 Mar 2015 14:30:21 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id a13sm17442272wjx.30.2015.03.30.14.30.20 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Mar 2015 14:30:20 -0700 (PDT) From: Thomas Monjalon To: Ravi Kerur Date: Mon, 30 Mar 2015 23:29:40 +0200 Message-ID: <1722908.xonNXe7smH@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1420565095-17278-1-git-send-email-rkerur@gmail.com> References: <1420565095-17278-1-git-send-email-rkerur@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, rkerur@brocade.com Subject: Re: [dpdk-dev] [PATCH v4 0/7] Move EAL common function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Mar 2015 21:30:22 -0000 Hi Ravi, 2015-01-06 12:24, Ravi Kerur: > Fix v3 PATCH review comments from Thomas. > eal_common.c is further split into eal_common_system.c and > eal_common_runtime.c files with appropriate functions. > eal_externs.h file is removed and _get_ and _set_ APIs are > used to access variables. > Functions with same signature in Linux and BSD but different > names are kept intact but Linux function name is used as > wrapper for BSD. > Added eal_pci.c in v4 PATCH. > New files added follow _common_ naming conventions. > Tested against Ubuntu and FreeBSD. > > Ravi Kerur (7): > Move common functions in eal_debug.c > Move common functions in eal_thread.c > Move common functions in eal.c > Move common functions in eal_lcore.c > Move common functions in eal_timer.c > Move common functions in eal_memory.c > Move common functions in eal_pci.c Sorry for not integrating this big refactoring in release 2.0. It wasn't easy to merge it during development of some EAL features. And it's now too risky to rework it before the release. I think this clean-up is needed and should be done at the beginning of 2.1 cycle. We just need to rebase it and remove the "ifdef BSD/LINUX" which was introduced in pci code. Do you think you'll have time for it? Thanks