From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id B920B2904
 for <dev@dpdk.org>; Tue,  9 Jan 2018 18:23:05 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 3A8E22016D;
 Tue,  9 Jan 2018 12:23:05 -0500 (EST)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Tue, 09 Jan 2018 12:23:05 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=03X8W7xHzsy6rlYSgQn4+U4MXt
 NrUftB5MzUfYmqdPw=; b=dJnxA/CJa9mFQ8TOHsaDeFqthcDPVyyGmLBuLkZXy+
 /2jpdbgyacRe0ESuktegNPU7vFQFmC1saRA4zF+9ZzW2sY4RUXAJrCyB6VlPOwX9
 SsmJiHZX0cY7DSrd36u5w+YY1ZDOnXq5g9fuRRlH2hPqlrMN3Mulej08Vbe02+Qo
 Q=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=03X8W7
 xHzsy6rlYSgQn4+U4MXtNrUftB5MzUfYmqdPw=; b=GUrlu3okd3p+g0/cyU77fu
 iLBf3waPE5rzMLaqVJIS9JM6O4TM8ggQXPWlmaaqV9+/jjLPXQPab6QIXd9tdKgV
 OAI6RHfS6pUvyFRStra+QIiXEGyJv5bkGzUDf4qojdLCuvyKOz1PTbpFiw4LwaZg
 XiMwUO4gxf1TTSn/QDEi+Dwspgczs53v/ItyvTLI/qzIBKT96qL/iFnfwOoQKPEA
 r1fWmbVRK9Ve13v/0WLZFfaQB5ouvcnif6odFhsk4Sdg5WSFA8g4d3y6OQSjj0Kp
 1667vPU17nm3geI2V3clNOlGqvkvIfT2K1Q4FCD6G8BZyJBlvwWaFmEbkq2mzeuQ
 ==
X-ME-Sender: <xms:efpUWvWSlpiu1ndsa94NxsXI4CRYMQv5zvr8tWMlhjiUDBJztIEFng>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id D48F27E16A;
 Tue,  9 Jan 2018 12:23:04 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Xiao Wang <xiao.w.wang@intel.com>
Cc: yliu@fridaylinux.org, tiwei.bie@intel.com, dev@dpdk.org,
 stephen@networkplumber.org, maxime.coquelin@redhat.com
Date: Tue, 09 Jan 2018 18:22:40 +0100
Message-ID: <1723302.rTpf7COCtA@xps>
In-Reply-To: <20180109160918.29173-4-xiao.w.wang@intel.com>
References: <20180109132654.3504-4-xiao.w.wang@intel.com>
 <20180109160918.29173-1-xiao.w.wang@intel.com>
 <20180109160918.29173-4-xiao.w.wang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v9 3/5] net: add a helper for making RARP
	packet
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Jan 2018 17:23:05 -0000

09/01/2018 17:09, Xiao Wang:
> --- a/lib/librte_net/rte_arp.h
> +++ b/lib/librte_net/rte_arp.h
> @@ -76,6 +76,20 @@ struct arp_hdr {
>  	struct arp_ipv4 arp_data;
>  } __attribute__((__packed__));
>  
> +/**
> + * Make a RARP packet based on MAC addr.
> + *
> + * @param mbuf
> + *   Pointer to the rte_mbuf structure
> + * @param mac
> + *   Pointer to the MAC addr
> + *
> + * @return
> + *   - 0 on success, negative on error
> + */
> +int
> +rte_net_make_rarp_packet(struct rte_mbuf *mbuf, const struct ether_addr *mac);

Please check how experimental state is advertised for other functions.
Usually we add a bold doxygen comment.

[...]
> --- a/lib/librte_net/rte_net_version.map
> +++ b/lib/librte_net/rte_net_version.map
> +EXPERIMENTAL {
> +	global:
> +
> +	rte_net_make_rarp_packet;
> +} DPDK_17.05;
>