From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 67B3844CF for ; Sun, 21 Jan 2018 11:52:55 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E155520988; Sun, 21 Jan 2018 05:52:54 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Sun, 21 Jan 2018 05:52:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=BfJg+PmJ1iUyQuow+iC4SOAJqL Two3s4y8RVRpSNmM0=; b=kuDBfojt/apyvpOVPbnjE7fwC0pd3Iao0yNi8jAgIM /49AHm8iIVrowPbavFcMLH+rCpHloSlNCJCPH3SNJTLioP4f/tgCUQzIENlBTvuz Rs6RYb7TsgiY7LYX6cCeWQbEBsQJVr2q/h+WehaVz+ZMrVnivJ9MARDJOcCRvmN6 k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=BfJg+P mJ1iUyQuow+iC4SOAJqLTwo3s4y8RVRpSNmM0=; b=HKoEzS9a5gz9E37Ch+et5n PL8U47b8H5BtZKzdQZAV+WZWOlc6t36iysOKRud6baLPxw7R9ioGCli1DV8KF5Vf aF8ZhnUKjoAWhnPWLTWK27CaAcww8TEjgBf6bqqqGvZ9lETvXu728ozfoARiz6wa S8kMg/pmnGpW5SnssrCtp/di1CqkfH032wrYDldwp2F3vAi/LgOObpj8dZbJG3CX QqVbvLmbsE68WgmLN178QkjwrzcWPsYF2idRgW1B7c0SQcu67J9rtGZw7o9Wtec2 qr/6HUQi4PFW5E856PcDTGwBSiM8DH4VP+cWC5RRzlHFFWJKlkaerbBn1cOMwRDA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9C5007E13A; Sun, 21 Jan 2018 05:52:54 -0500 (EST) From: Thomas Monjalon To: Andrew Rybchenko Cc: dev@dpdk.org, Liang Ma , Peter Mccarthy , Jerin Jacob Date: Sun, 21 Jan 2018 11:52:17 +0100 Message-ID: <1723597.5t6EeO7jYB@xps> In-Reply-To: <1516528119-720-1-git-send-email-arybchenko@solarflare.com> References: <1516528119-720-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] event/opdl: fix build using C99 mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Jan 2018 10:52:55 -0000 21/01/2018 10:48, Andrew Rybchenko: > RHEL 7.4 gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16) >=20 > =E2=80=98for=E2=80=99 loop initial declarations are only allowed in C99 m= ode >=20 > Fixes: 4236ce9bf5bf ("event/opdl: add OPDL ring infrastructure library") >=20 > Signed-off-by: Andrew Rybchenko > --- > Other option is to move declarations outside of for loop. > I just want it to be fixed. Yes, other option would be to comply with DPDK coding style. Let's fix it with std=3DC99, waiting for coding style fix. Applied, thanks