From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45BCAA034F; Fri, 8 Oct 2021 12:33:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 362F2410E0; Fri, 8 Oct 2021 12:33:45 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 53CCE410DC for ; Fri, 8 Oct 2021 12:33:43 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C0F5B5C0143; Fri, 8 Oct 2021 06:33:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 08 Oct 2021 06:33:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= Rk//s2gdAwEzgSjEZFdTYE5t65Sm7/JmKCs9chI/rvU=; b=T1gBvMJIHN6+RFpJ auKYJvzXLBsIEIXi6Ma+87EiTEOvmbbQ40baih3+/fehcW14U01DCDVre7+9zNpV h26hYT954wESTKAgURbYmMbtzB6QXyhwsJEGDGoDopVrzgZPEVB0jCbVTCbPGuFK FQ7K1X22kpG9NSbBVyIwbrOH1Hya8wZ6WpVHT6+eJRmM86XnVGkLmUofoaO/J4vg yWrsd/vwsOy4s7CZ1YVcAMrdkOsY092FBj3wG6pZgelKFBB1y3+4euRWHah2lFyw 6hzkGukODg3qJov6cTGkfqVS2AvU9W+QkOqmFV68zGOyQe6Na/6G+u8VAKjJ1NO+ UkLnuw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Rk//s2gdAwEzgSjEZFdTYE5t65Sm7/JmKCs9chI/r vU=; b=PED//T9X9xo+HCsetW4akFjXkQ93adaGgYUzUjwA2PPtDFsoLAloNCDy7 vSXyQjBgxnrYx7OPAVZ6dsP4BV2hlWnQHXzJbE+jdgPKSlIufP5jWeftxWdpB1/9 v+bTeDLOsaPsnEN6Bxaa61YSwOZXVAM6JH+mSooEv6ubLNQ4R7sKQxrYxe+b3wQs U+mciicu+DBMz9IiD8sOXjypXJCuCnJH0wFZ5dzg4f8oSr77kgCIBGLaOV9rTGCW fC206owp9suOfnX5Eib6ZILpYG9VWz7fY6WbTElSo7YJ3H4Z5IKAyEMJzSu79mR3 AyNqHDLzXj9gaUs4IdPRq4d+thwEw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddttddgvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Oct 2021 06:33:40 -0400 (EDT) From: Thomas Monjalon To: Huisong Li Cc: dev@dpdk.org, ferruh.yigit@intel.com, aman.deep.singh@intel.com, andrew.rybchenko@oktetlabs.ru, anatoly.burakov@intel.com, lihuisong@huawei.com Date: Fri, 08 Oct 2021 12:23:05 +0200 Message-ID: <1723716.XTA6elxnGa@thomas> In-Reply-To: <20211008082114.22468-1-lihuisong@huawei.com> References: <1627908397-51565-1-git-send-email-lihuisong@huawei.com> <20211008082114.22468-1-lihuisong@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: fix eth device released repeatedly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/10/2021 10:21, Huisong Li: > In secondary process, because it doesn't clear eth_dev->data, the "eth_dev" > above will not be NULL when rte_eth_dev_close() has been called before this > interface is called. In this case, Ethernet device will be released > repeatedly. The state of the Ethernet device is equal to RTE_ETH_DEV_UNUSED > after calling rte_eth_dev_close(). Using this state resolves problem. Sorry I have difficulties to understand. The use of "it" everywhere doesn't help. You should name things instead of refering to "it". > Fixes: 99a2dd955fba ("lib: remove librte_ prefix from directory names") For sure that's not the root cause.