From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42])
by dpdk.org (Postfix) with ESMTP id 01523C134
for <dev@dpdk.org>; Tue, 16 Feb 2016 17:20:41 +0100 (CET)
Received: by mail-wm0-f42.google.com with SMTP id a4so107914218wme.1
for <dev@dpdk.org>; Tue, 16 Feb 2016 08:20:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=from:to:cc:subject:date:message-id:organization:user-agent
:in-reply-to:references:mime-version:content-transfer-encoding
:content-type; bh=XpX5VTLxbLXvo7DectiJ2OLfbe/H8FuZTl6weY/+mDA=;
b=jT3/sJtMjJOZAGW/iSvTqSaPawgP2yv5kW+wQGrVkX4f/0tfYPMjYZQfOCbMaodIiH
BLP1klBu9CbLBh7mkzqz0hIPklhoGxP55AySb3cuA4HshXCYrXPtz8VG+DcQtgKMxOp3
XwB/GS+lb4Uf8K1q1qNCNuxjehDcPgdDxfu5LdqrbVdDnuKbO+U9QnGYC+7AfxPcrI8O
otQQdymT+U6Qvj9gB3azqYUVB7tDjFGSwkwb/OVWUeDdOJGTFVY7Bt4NfLVblq8G+Y/n
zAWNTPvpyvvpeX1WK7/aaasF83o+pvuOLGx06W34VGtqb1XEpvLWEUARjhwZlkfJoUIb
RyWQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
:user-agent:in-reply-to:references:mime-version
:content-transfer-encoding:content-type;
bh=XpX5VTLxbLXvo7DectiJ2OLfbe/H8FuZTl6weY/+mDA=;
b=DdlcWwUhQwX/qLcuDL7UPpQgxKsXK3H3W4RqJoI+P7DOAkeWyxQZj8jdmvKO55bFR9
eZhYkYv6FXwbuUb8i+tsJGitLaQfM3bWSivJltYdATUwJGAmgxm69lxFT6tGTkQZAfl/
Pa+4EL1vV6tJ4+QT+VrTBT1M/aTslERWNqT11X5l/gCPbl29mWl0VSr/ioZIeMBe6qM1
Os3UV3WmHworUSooFihLiQvm00KbNfIdDnHUUnBHX2eMqA+KF6opc3hVZlg3JAecnfdt
fS79r0qk0EI15fSMLgPD06MQr4lznY3pvU6NwN0NxhTgP9WnRO3X+gwTFfalwB8/tSN6
EG0w==
X-Gm-Message-State: AG10YOTnm2XqIVYAUO1k7CcRRZ4gQ1N44TSoWreZca4wHHi9vSRcjqd/SQP26RBDg40pJEsw
X-Received: by 10.194.94.229 with SMTP id df5mr27389183wjb.133.1455639641807;
Tue, 16 Feb 2016 08:20:41 -0800 (PST)
Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.
[82.239.227.177])
by smtp.gmail.com with ESMTPSA id c26sm21193828wmi.24.2016.02.16.08.20.40
(version=TLSv1/SSLv3 cipher=OTHER);
Tue, 16 Feb 2016 08:20:40 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Wojciech Andralojc <wojciechx.andralojc@intel.com>
Date: Tue, 16 Feb 2016 17:19:09 +0100
Message-ID: <1723784.P3p8rzzn5a@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1454073434-92991-1-git-send-email-wojciechx.andralojc@intel.com>
References: <1454073434-92991-1-git-send-email-wojciechx.andralojc@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lib: Initial implementation of PQoS lib with
CAT and CDP support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Feb 2016 16:20:42 -0000
Hi,
2016-01-29 13:17, Wojciech Andralojc:
> 25 files changed, 2111 insertions(+)
The patch is too big to be easily reviewed.
> +PQoS API
> +M: Kantecki, Tomasz <tomasz.kantecki@intel.com>
> +K: RTE_LIBRTE_PQOS
> +F: lib/librte_pqos/
>
> Drivers
> -------
> diff --git a/config/common_linuxapp b/config/common_linuxapp
> index 74bc515..553e640 100644
> --- a/config/common_linuxapp
> +++ b/config/common_linuxapp
> @@ -99,6 +99,7 @@ CONFIG_RTE_NEXT_ABI=y
> CONFIG_RTE_LIBRTE_EAL=y
> CONFIG_RTE_MAX_LCORE=128
> CONFIG_RTE_MAX_NUMA_NODES=8
> +CONFIG_RTE_MAX_PHY_PKGS=8
The physical packages management should be a separate patch.
> CONFIG_RTE_MAX_MEMSEG=256
> CONFIG_RTE_MAX_MEMZONE=2560
> CONFIG_RTE_MAX_TAILQ=32
> @@ -514,6 +515,13 @@ CONFIG_RTE_LIBRTE_VHOST_NUMA=n
> CONFIG_RTE_LIBRTE_VHOST_DEBUG=n
>
> #
> +# Compile librte_pqos
> +# IA only
> +# LIBRTE_PQOS is for librte_pqos only
I think this line is not needed.
> +CONFIG_RTE_LIBRTE_PQOS=n
> +CONFIG_RTE_LIBRTE_PQOS_DEBUG=n
> --- a/lib/librte_eal/common/eal_private.h
> +++ b/lib/librte_eal/common/eal_private.h
> @@ -346,4 +346,13 @@ int rte_eal_hugepage_init(void);
> */
> int rte_eal_hugepage_attach(void);
>
> +#ifdef RTE_LIBRTE_PQOS
> +/**
> + * Get cpu physical_package_id.
> + *
> + * This function is private to the EAL.
> + */
> +unsigned eal_cpu_phy_pkg_id(unsigned lcore_id);
> +#endif
No need to restrict this function to LIBRTE_PQOS.
Maybe it should be a public API.
> --- a/lib/librte_eal/common/include/rte_log.h
> +++ b/lib/librte_eal/common/include/rte_log.h
> @@ -79,6 +79,9 @@ extern struct rte_logs rte_logs;
> #define RTE_LOGTYPE_PIPELINE 0x00008000 /**< Log related to pipeline. */
> #define RTE_LOGTYPE_MBUF 0x00010000 /**< Log related to mbuf. */
> #define RTE_LOGTYPE_CRYPTODEV 0x00020000 /**< Log related to cryptodev. */
> +#ifdef RTE_LIBRTE_PQOS
> +#define RTE_LOGTYPE_PQOS 0x00040000 /**< Log related to pqos. */
> +#endif
The ifdef is useless and forbidden in a header.
> --- a/lib/librte_eal/linuxapp/eal/Makefile
> +++ b/lib/librte_eal/linuxapp/eal/Makefile
> @@ -45,6 +45,9 @@ CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/include
> CFLAGS += -I$(RTE_SDK)/lib/librte_ring
> CFLAGS += -I$(RTE_SDK)/lib/librte_mempool
> CFLAGS += -I$(RTE_SDK)/lib/librte_ivshmem
> +ifeq ($(CONFIG_RTE_LIBRTE_PQOS),y)
> +CFLAGS += -I$(RTE_SDK)/lib/librte_pqos
> +endif
Please make EAL independent of librte_pqos.
> +++ b/lib/librte_pqos/rte_pqos_version.map
> @@ -0,0 +1,16 @@
> +DPDK_2.3 {
It will be DPDK_16.04.
I won't comment the library itself in this version.
Please rework EAL and patch splitting first.
Thanks