From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by dpdk.org (Postfix) with ESMTP id 11D3E68A1 for ; Wed, 14 May 2014 13:55:32 +0200 (CEST) Received: by mail-we0-f177.google.com with SMTP id x48so1802928wes.36 for ; Wed, 14 May 2014 04:55:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=TsOkIgXhfcIzVh5PsqVXum+CWIb8Ngd5BVVYZwLgJug=; b=JbS/w5/Y4WHomyWF7XeocudTJ8W2Asy1dE9l+eKez+7eiJqdrpvRihqwxbNTxqfoBk fQffBD+uJgLAxbK//v2AymRcqETlrQS8GGMr/XM2dpn4mD+iIrn5xRIjQu/qHpoOtETJ Qq8NIzWV7M5nSEpLF52pETYp5xg5DvzfDqm1d8qbPPCgZYaI7yA3E4VPKTshr0Ul6bli 8XmrrBqUttUX5lqqw0FGsU5PthNlIB+2P9LIMkuHq8LIhf2RmNWij6vSW6mVL6EH2WzC veJqXhC8G8DaG0Tm0xKo4sI1y+tTKCDnGgS8vDK7W2ZZLc/MsTPMgDo2wUxVckZlRrMp YXTQ== X-Gm-Message-State: ALoCoQkkzDN3hg8ortCyfrRyq31cPgVgPgR98bPZcuCInSyUIgV1JlCccpkIKN8n0diSkRhvpnwh X-Received: by 10.180.85.10 with SMTP id d10mr25781233wiz.0.1400068540617; Wed, 14 May 2014 04:55:40 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id km6sm2235205wjc.6.2014.05.14.04.55.39 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 May 2014 04:55:39 -0700 (PDT) From: Thomas Monjalon To: "Richardson, Bruce" Date: Wed, 14 May 2014 13:55:38 +0200 Message-ID: <1725713.WtaYEVcYoT@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.2-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: <59AF69C657FD0841A61C55336867B5B01AA196E4@IRSMSX103.ger.corp.intel.com> References: <1400062955-27338-1-git-send-email-bruce.richardson@intel.com> <3983181.2kuc6T3mxt@xps13> <59AF69C657FD0841A61C55336867B5B01AA196E4@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: allow updates to build config on make install X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 May 2014 11:55:33 -0000 2014-05-14 10:51, Richardson, Bruce: > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Wednesday, May 14, 2014 11:34 AM > > To: Richardson, Bruce > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] mk: allow updates to build config on make > > install > > > > Hi Bruce > > > > 2014-05-14 11:22, Bruce Richardson: > > > There was an issue with rebuilding the code following a change to one > > > of the config files inside the "config" directory. If one did a "make > > > install T=" and then made a modification to the > > > defconfig_ file (or applied a patch which modified that file) > > > a subsequent re-run of the make install command would not rebuild the > > > .config file leading to either build failures or an incorrect build. > > > This change fixes that issue. > > > > Your patch is reverting this one: > > mk: in install rule, don't overwrite .config if it already exists > > http://dpdk.org/browse/dpdk/commit/?id=1c858a7dfebd4e4092eb55 > > > > As stated in the commit log, > > > > "This allows the user to prepare a configuration with make config > > before using make install." > > > > So your patch is introducing a regression. > > > > I think you are describing something which is not a bug. > > If you make a modification to the configuration template, you must > > explicitly call "make config". > > Ok, thanks for that Thomas. > However, I still think we have a bug here, or at least we need some > discussion on the correct behaviour we expect to have. From my point of > view, the new behaviour is problematic, as every time I apply a patch or do > a pull, I need to do a "make uninstall" or "make config" before doing "make > install" just in case something has changed in the defconfig file, even if > I have changed nothing on my end. This is not expected behaviour: if a > change is made to the repository, doing a rebuild should rebuild > everything which needs to be built to take account of that change. You would like to have a synchronization of your generated .config file with the configuration template. But it's not possible for the simple reason that you may have modified your .config file so there is no simple correlation with the original template. -- Thomas