From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 6F798AAA0
for <dev@dpdk.org>; Mon, 16 Apr 2018 18:56:41 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 0D1AC211C9;
Mon, 16 Apr 2018 12:56:41 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Mon, 16 Apr 2018 12:56:41 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc; s=mesmtp; bh=pRZINgyEarAiAmGq+7sRkvPY8B
AYdG/+KbuFgggjkDk=; b=Dw14jITMghd2X4nvEKPXPpXt04IzB52LxF4ppDaK47
dH6RRaqCMf6JBBWcsEpmY60GjwqXmi/ihooVg/PMK7Qb5evRS+LtbNwkGESnAJNp
v5FgnbS59WNHLggMupJpKuV6yqbyibXFCeB6PE7O7rZyRWtPBQwiXc6fib9xP1FB
o=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=pRZINg
yEarAiAmGq+7sRkvPY8BAYdG/+KbuFgggjkDk=; b=M6+a33MdHIvzIXVTbM0q5Z
kJgFEM10LBqKfncJiQsT5YcshvQe6DWqphPVdpR/2Jhcq6ntHYH+NGnRgPzcl0N4
cM0z4oJkida/ZDB0qwB115XVguaKxDjvTo6y8NYwCDwuEvV7K1dLSE67n6pMFVcC
t/D+6/mkMLQPvtDJZdvobeyQSJDQsr5jrP/1UOKqqI+9Pavhj0MFtmhWg4HkFOV3
/twNp0JRGYVxZsWVIRyv0WcPW1FUkkUAYyeAcFshf8pUiWaja+5IG8ZD4MBmFOmb
aYXj+GBFkrz1IUar7dKHJRxI9BFUSSqTiFkw87z+qgE2lYrXLNZusQYwAuIx3TlQ
==
X-ME-Sender: <xms:yNXUWi4jckxHE2ISpkQcsIU9sK6al0ICyoQKymEhVflweU5V_ZyhTQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 67B03E46C2;
Mon, 16 Apr 2018 12:56:40 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, wenzhuo.lu@intel.com
Date: Mon, 16 Apr 2018 18:56:39 +0200
Message-ID: <1726566.h1n8icGdPe@xps>
In-Reply-To: <20180416133911.289196-1-bruce.richardson@intel.com>
References: <20180416133911.289196-1-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix compilation when vector
driver disabled
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Apr 2018 16:56:41 -0000
16/04/2018 15:39, Bruce Richardson:
> The new functions for Rx and Tx offloads should not be inside the
> conditional block for the vector driver, otherwise compile errors occur
> when vector driver is disabled. For example:
>=20
> ixgbe_ethdev.c:3636:36: error: implicit declaration of function =E2=80=
=98ixgbe_get_rx_queue_offloads=E2=80=99;
>=20
> This shows up as an error when doing ARM builds using meson as the vector
> driver is not (yet) enabled for those builds.
>=20
> Fixes: 51215925a32f ("net/ixgbe: convert to new Tx offloads API")
> Fixes: ec3b1124d14d ("net/ixgbe: convert to new Rx offloads API")
>=20
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks