* [dpdk-dev] [PATCH] lib: librte_ether: fix RTE_PMD_DEBUG_TRACE macro
@ 2015-12-06 13:13 Yaacov Hazan
2015-12-06 15:17 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Yaacov Hazan @ 2015-12-06 13:13 UTC (permalink / raw)
To: dev
RTE_PMD_DEBUG_TRACE was changed also to support pedantic flag,
but not completely.
the macro changed only under the RTE_LIBRTE_ETHDEV_DEBUG define,
but when RTE_LIBRTE_ETHDEV_DEBUG is not defined the old format
was left.
fix the macro to support pedantic flag in any case.
Signed-off-by: Yaacov Hazan <yaacovh@mellanox.com>
---
lib/librte_ether/rte_ethdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 1ff29e2..bada8ad 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -938,7 +938,7 @@ TAILQ_HEAD(rte_eth_dev_cb_list, rte_eth_dev_callback);
#define RTE_PMD_DEBUG_TRACE(...) \
rte_pmd_debug_trace(__func__, __VA_ARGS__)
#else
-#define RTE_PMD_DEBUG_TRACE(fmt, args...)
+#define RTE_PMD_DEBUG_TRACE(...)
#endif
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] lib: librte_ether: fix RTE_PMD_DEBUG_TRACE macro
2015-12-06 13:13 [dpdk-dev] [PATCH] lib: librte_ether: fix RTE_PMD_DEBUG_TRACE macro Yaacov Hazan
@ 2015-12-06 15:17 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2015-12-06 15:17 UTC (permalink / raw)
To: Yaacov Hazan; +Cc: dev
2015-12-06 15:13, Yaacov Hazan:
> RTE_PMD_DEBUG_TRACE was changed also to support pedantic flag,
> but not completely.
>
> the macro changed only under the RTE_LIBRTE_ETHDEV_DEBUG define,
> but when RTE_LIBRTE_ETHDEV_DEBUG is not defined the old format
> was left.
>
> fix the macro to support pedantic flag in any case.
>
> Signed-off-by: Yaacov Hazan <yaacovh@mellanox.com>
Fixes: b974e4a40cb5 ("ethdev: make error checking macros public")
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-06 15:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-06 13:13 [dpdk-dev] [PATCH] lib: librte_ether: fix RTE_PMD_DEBUG_TRACE macro Yaacov Hazan
2015-12-06 15:17 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).