From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 05C2F45C82;
Tue, 5 Nov 2024 04:18:56 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 2E8B642D2B;
Tue, 5 Nov 2024 04:17:55 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
by mails.dpdk.org (Postfix) with ESMTP id 80E2D427A6
for <dev@dpdk.org>; Tue, 5 Nov 2024 04:17:38 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1213)
id 0C5312127C85; Mon, 4 Nov 2024 19:17:36 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0C5312127C85
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
s=default; t=1730776657;
bh=L5qdNGqxdT35/n2nM9hNWt2L3xOZq+3iQ+slN4D+iqg=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=cvDo1YA72q2BmG+GvDDJG39ppQjxj5JdU9Cz787R3AaxXaCEL68INt7nYoMDqq99X
3PMjcrRc0OUKDoarFyKk7CLDHAfif27oyUeQgaRNBxqHxs4EE6/Rd/912I5G2joHAq
cddzrJeLMMmkynZbaqW+pa353PN69nadTDkWubC4=
From: Andre Muezerie <andremue@linux.microsoft.com>
To: stephen@networkplumber.org
Cc: aman.deep.singh@intel.com, anatoly.burakov@intel.com,
andrew.rybchenko@oktetlabs.ru, bruce.richardson@intel.com, dev@dpdk.org,
dmitry.kozliuk@gmail.com, dsosnowski@nvidia.com, fanzhang.oss@gmail.com,
fengchengwen@huawei.com, ferruh.yigit@amd.com, gakhil@marvell.com,
harry.van.haaren@intel.com, hkalra@marvell.com,
honnappa.nagarahalli@arm.com, hujiayu.hu@foxmail.com,
jingjing.wu@intel.com, kevin.laatz@intel.com,
konstantin.v.ananyev@yandex.ru, matan@nvidia.com, mb@smartsharesystems.com,
orika@nvidia.com, pallavi.kadam@intel.com, reshma.pattan@intel.com,
roretzla@linux.microsoft.com, sameh.gobriel@intel.com,
suanmingm@nvidia.com, thomas@monjalon.net, vfialko@marvell.com,
viacheslavo@nvidia.com, vladimir.medvedkin@intel.com,
yipeng1.wang@intel.com
Subject: [PATCH v4 17/19] build: enable vla warnings on Windows built code
Date: Mon, 4 Nov 2024 19:15:51 -0800
Message-Id: <1730776553-31277-18-git-send-email-andremue@linux.microsoft.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1730776553-31277-1-git-send-email-andremue@linux.microsoft.com>
References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>
<1730776553-31277-1-git-send-email-andremue@linux.microsoft.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
MSVC does not support optional C11 VLAs. When building for Windows
enable -Wvla so that mingw and clang also fail if a VLA is used.
Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
config/meson.build | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/config/meson.build b/config/meson.build
index 5095d2fbcb..9a3ce5eaa9 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -339,6 +339,10 @@ if cc.get_id() == 'intel'
warning_flags += '-diag-disable=@0@'.format(i)
endforeach
endif
+# no VLAs in code built on Windows
+if is_windows
+ warning_flags += '-Wvla'
+endif
foreach arg: warning_flags
if cc.has_argument(arg)
add_project_arguments(arg, language: 'c')
--
2.34.1