From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 9EBDE45D6C;
Thu, 21 Nov 2024 20:25:22 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 8D22043342;
Thu, 21 Nov 2024 20:23:55 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
by mails.dpdk.org (Postfix) with ESMTP id 8832F42FBF
for <dev@dpdk.org>; Thu, 21 Nov 2024 20:23:31 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1213)
id 0B46A23834C7; Thu, 21 Nov 2024 11:23:29 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0B46A23834C7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
s=default; t=1732217010;
bh=ofHrC/Rqtx94ztsCmYAlUEDMQs2hlSp8MggnTLjScUY=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=oyzBftZiN03Xf87lB6/kOW0u6u8KKvBp5zGwi0QiYhvf0Nb/PSPjE9t3/nuTuatYA
ubS4jZpp+VEy5rQKlikfsXTWKaW1mXuRULUyXxjXAFnlekpqHYta+36skoHORwbJF7
e0wl9KdKFLrnz19Ds1W/AmuA9TuB6B3/z8RJ4Aso=
From: Andre Muezerie <andremue@linux.microsoft.com>
To: dev@dpdk.org
Cc: Andre Muezerie <andremue@linux.microsoft.com>
Subject: [PATCH v11 21/21] hash: remove use of VLAs by using standard arrays
Date: Thu, 21 Nov 2024 11:23:18 -0800
Message-Id: <1732216998-3899-22-git-send-email-andremue@linux.microsoft.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1732216998-3899-1-git-send-email-andremue@linux.microsoft.com>
References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>
<1732216998-3899-1-git-send-email-andremue@linux.microsoft.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
MSVC does not support VLAs, replace VLAs with standard C arrays.
Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
lib/hash/rte_thash_gf2_poly_math.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/lib/hash/rte_thash_gf2_poly_math.c b/lib/hash/rte_thash_gf2_poly_math.c
index 1c62974e71..825da4382f 100644
--- a/lib/hash/rte_thash_gf2_poly_math.c
+++ b/lib/hash/rte_thash_gf2_poly_math.c
@@ -8,6 +8,7 @@
#include <rte_thash.h>
#include <rte_log.h>
+#define MAX_POLY_DEGREE 32
#define MAX_TOEPLITZ_KEY_LENGTH 64
RTE_LOG_REGISTER_SUFFIX(thash_poly_logtype, thash_poly, INFO);
#define RTE_LOGTYPE_HASH thash_poly_logtype
@@ -149,7 +150,7 @@ gf2_pow(uint32_t a, uint32_t pow, uint32_t r, int degree)
static uint32_t
__thash_get_rand_poly(int poly_degree)
{
- uint32_t roots[poly_degree];
+ uint32_t roots[MAX_POLY_DEGREE];
uint32_t rnd;
uint32_t ret_poly = 0;
int i, j;
@@ -194,9 +195,7 @@ __thash_get_rand_poly(int poly_degree)
* Get coefficients of the polynomial for
* (x - roots[0])(x - roots[1])...(x - roots[n])
*/
- uint32_t poly_coefficients[poly_degree + 1];
- for (i = 0; i <= poly_degree; i++)
- poly_coefficients[i] = 0;
+ uint32_t poly_coefficients[MAX_POLY_DEGREE + 1] = {0};
poly_coefficients[0] = 1; /* highest degree term coefficient in the end */
for (i = 0; i < (int)poly_degree; i++) {
@@ -247,7 +246,7 @@ thash_get_rand_poly(uint32_t poly_degree)
{
uint32_t ret_poly;
- if (poly_degree > 32) {
+ if (poly_degree > MAX_POLY_DEGREE) {
HASH_LOG(ERR, "Wrong polynomial degree %d, must be in range [1, 32]", poly_degree);
return 0;
}
--
2.47.0.vfs.0.3