From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F05F45E33; Wed, 4 Dec 2024 22:41:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0630940EDF; Wed, 4 Dec 2024 22:41:16 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 541C9402E3 for ; Wed, 4 Dec 2024 22:41:10 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id 7FE7020CECB0; Wed, 4 Dec 2024 13:41:09 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7FE7020CECB0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1733348469; bh=BRxkRc56Gio2Og7PA3iGlDu6oxYoJ72iGnpyDiSQBX4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Jizmalfnc5oiHR37fzUpdXgnOzRieYS6N/a4M8XZDwtyK7WDw9bljhSlZw64bIdOH bZ5WdgUqgwmPO8lbyyyt/PY3XVJPdIkJlz8HHoPU6jDOoZzOI/UqNDiuhYQ3pM84Pv aeaFJIroZ4N7XVE8d/jnq40Dfa1XDXEyriMcPpDw= From: Andre Muezerie To: dev@dpdk.org Cc: Andre Muezerie Subject: [PATCH v2 3/6] drivers/dma: eliminate dependency on non-portable __SIZEOF_LONG__ Date: Wed, 4 Dec 2024 13:41:03 -0800 Message-Id: <1733348466-16057-4-git-send-email-andremue@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1733348466-16057-1-git-send-email-andremue@linux.microsoft.com> References: <1733342995-3722-2-git-send-email-andremue@linux.microsoft.com> <1733348466-16057-1-git-send-email-andremue@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Macro __SIZEOF_LONG__ is not standardized and MSVC does not define it. Therefore the errors below are seen with MSVC: ../lib/mldev/mldev_utils_scalar.c(465): error C2065: '__SIZEOF_LONG__': undeclared identifier ../lib/mldev/mldev_utils_scalar.c(478): error C2051: case expression not constant ../lib/mldev/mldev_utils_scalar_bfloat16.c(33): error C2065: '__SIZEOF_LONG__': undeclared identifier ../lib/mldev/mldev_utils_scalar_bfloat16.c(49): error C2051: case expression not constant Turns out that the places where __SIZEOF_LONG__ is currently being used can equally well use sizeof(long) instead. Signed-off-by: Andre Muezerie --- drivers/dma/dpaa/dpaa_qdma.h | 2 +- drivers/dma/hisilicon/hisi_dmadev.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/dpaa/dpaa_qdma.h b/drivers/dma/dpaa/dpaa_qdma.h index 579483ac34..3736c0d431 100644 --- a/drivers/dma/dpaa/dpaa_qdma.h +++ b/drivers/dma/dpaa/dpaa_qdma.h @@ -14,7 +14,7 @@ #define RETRIES 5 #ifndef GENMASK -#define BITS_PER_LONG (__SIZEOF_LONG__ * 8) +#define BITS_PER_LONG (sizeof(long) * 8) #define GENMASK(h, l) \ (((~0UL) << (l)) & (~0UL >> (BITS_PER_LONG - 1 - (h)))) #endif diff --git a/drivers/dma/hisilicon/hisi_dmadev.h b/drivers/dma/hisilicon/hisi_dmadev.h index 786fe3cc0e..777b9dd704 100644 --- a/drivers/dma/hisilicon/hisi_dmadev.h +++ b/drivers/dma/hisilicon/hisi_dmadev.h @@ -12,7 +12,7 @@ #include #define BIT(x) (1ul << (x)) -#define BITS_PER_LONG (__SIZEOF_LONG__ * 8) +#define BITS_PER_LONG (sizeof(long) * 8) #define GENMASK(h, l) \ (((~0UL) << (l)) & (~0UL >> (BITS_PER_LONG - 1 - (h)))) #define BF_SHF(x) rte_bsf64(x) -- 2.47.0.vfs.0.3