From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4CA6145E36; Thu, 5 Dec 2024 05:20:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AEAC242792; Thu, 5 Dec 2024 05:20:40 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 810274275D for ; Thu, 5 Dec 2024 05:20:36 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id A3FD320ACD63; Wed, 4 Dec 2024 20:20:35 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A3FD320ACD63 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1733372435; bh=vkRxwUTOE9FcEWss9FH7hR8UxwAb9HOiZ551AoOSUd8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R7EpxdzUQOlKFOYLGJsf8qKM4Jka6TUdN1RF8enn9R2S4QJNzpB8inrMKohhJoisU iSIj3rPkGBjaaWumnsnkMA4oQoejR/HSTlNFAWFK44h/0NZyhnUruD25zRkVpCE7fV L5CzSw/UJ1NfrU4vditJxvSgCmL5UCr6Jfe4bCHU= From: Andre Muezerie To: dev@dpdk.org Cc: Andre Muezerie Subject: [PATCH v3 1/7] lib/eal: eliminate dependency on non-portable __SIZEOF_LONG__ Date: Wed, 4 Dec 2024 20:20:23 -0800 Message-Id: <1733372429-3996-2-git-send-email-andremue@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1733372429-3996-1-git-send-email-andremue@linux.microsoft.com> References: <1733342995-3722-2-git-send-email-andremue@linux.microsoft.com> <1733372429-3996-1-git-send-email-andremue@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Macro __SIZEOF_LONG__ is not standardized and MSVC does not define it. Therefore the errors below are seen with MSVC: ../lib/mldev/mldev_utils_scalar.c(465): error C2065: '__SIZEOF_LONG__': undeclared identifier ../lib/mldev/mldev_utils_scalar.c(478): error C2051: case expression not constant ../lib/mldev/mldev_utils_scalar_bfloat16.c(33): error C2065: '__SIZEOF_LONG__': undeclared identifier ../lib/mldev/mldev_utils_scalar_bfloat16.c(49): error C2051: case expression not constant Turns out that the places where __SIZEOF_LONG__ is currently being used can equally well use sizeof(long) instead. Signed-off-by: Andre Muezerie --- lib/eal/include/rte_common.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h index 4d299f2b36..d2338366a4 100644 --- a/lib/eal/include/rte_common.h +++ b/lib/eal/include/rte_common.h @@ -603,6 +603,11 @@ rte_is_aligned(const void * const __rte_restrict ptr, const unsigned int align) */ #define RTE_BUILD_BUG_ON(condition) do { static_assert(!(condition), #condition); } while (0) +/*********** Data type size related macros ********/ + +#define RTE_BITS_PER_LONG (sizeof(long) * 8) +#define RTE_BITS_PER_LONG_LONG (sizeof(long long) * 8) + /*********** Cache line related macros ********/ /** Cache line mask. */ -- 2.47.0.vfs.0.3