From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: stephen@networkplumber.org
Cc: dev@dpdk.org, Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH v3 0/8] vmxnet3: driver updates
Date: Fri, 10 Jul 2015 00:32:29 +0200 [thread overview]
Message-ID: <1733770.SA3DFsV3Pz@xps13> (raw)
In-Reply-To: <D1C40EDB.4DB1B%yongwang@vmware.com>
2015-07-09 18:46, Yong Wang:
> On 7/9/15, 11:24 AM, "dev on behalf of stephen@networkplumber.org"
> <dev-bounces@dpdk.org on behalf of stephen@networkplumber.org> wrote:
> >From: Stephen Hemminger <shemming@brocade.com>
> >
> >These are update to earlier vmxnet3 driver changes. Mostly rebasing
> >to current layout. I skipped the jumbo MTU stuff which works for me
> >but reviewers seem to see problems with.
It should be possible to discuss with Yong to understand the problem
and submit a separate patch to get it approved.
> >Stephen Hemminger (8):
> > vmxnet3: enable VLAN filtering
> > vmxnet3: remove mtu check
> > vmxnet3: cleanup txq stats
> > vmxnet3: add support for multi-segment transmit
> > vmxnet3: fix link state handling
> > vmxnet3: support RSS and refactor offload
> > vmxnet3: get rid of DEBUG ifdefs
> > vmxnet3: remove unnecessary inlining
>
> Assuming this series is a simple rebase of the previous patchset, which I
> already acked (I didn’t see the Acked-by updated though in the new
> version):
Yes this series was partially ack'ed and some of them were forgotten in v3.
Stephen, reviewing is not so pleasant and it can be worst when some reviews
seem forgotten. Please try to add acks and maintain a changelog across
different versions of a patchset.
> Series Acked-by: Yong Wang <yongwang@vmware.com>
Applied, thanks for giving quick ack
next prev parent reply other threads:[~2015-07-09 22:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 18:24 stephen
2015-07-09 18:24 ` [dpdk-dev] [PATCH 1/8] vmxnet3: enable VLAN filtering stephen
2015-07-09 18:24 ` [dpdk-dev] [PATCH 2/8] vmxnet3: remove mtu check stephen
2015-07-09 18:24 ` [dpdk-dev] [PATCH 3/8] vmxnet3: cleanup txq stats stephen
2015-07-09 18:24 ` [dpdk-dev] [PATCH 4/8] vmxnet3: add support for multi-segment transmit stephen
2015-07-09 18:24 ` [dpdk-dev] [PATCH 5/8] vmxnet3: fix link state handling stephen
2015-07-09 18:24 ` [dpdk-dev] [PATCH 6/8] vmxnet3: support RSS and refactor offload stephen
2015-07-09 18:24 ` [dpdk-dev] [PATCH 7/8] vmxnet3: get rid of DEBUG ifdefs stephen
2015-07-09 18:24 ` [dpdk-dev] [PATCH 8/8] vmxnet3: remove unnecessary inlining stephen
2015-07-09 18:46 ` [dpdk-dev] [PATCH v3 0/8] vmxnet3: driver updates Yong Wang
2015-07-09 22:32 ` Thomas Monjalon [this message]
[not found] ` <73f62d318c9a4db790b71f334fd9354b@HQ1WP-EXMB11.corp.brocade.com>
2015-07-09 23:04 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1733770.SA3DFsV3Pz@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=shemming@brocade.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).