From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F91845E6F; Wed, 11 Dec 2024 03:06:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3176F40648; Wed, 11 Dec 2024 03:06:17 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 24BCA4042C for ; Wed, 11 Dec 2024 03:06:15 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id 6725A20BCAD0; Tue, 10 Dec 2024 18:06:14 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6725A20BCAD0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1733882774; bh=bWY/rlcRiIgOr8IGNJSuz1VmwD/+8KfkJxz5gs3pOOE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kU9Ne1Lb4nRTsZF3B1QH6CD+6iUfdxxqeLKMz7/KSolVzJS78C8QD4KMOaWDgjdQ4 MRQdQLZ+eWH9U5IslvPP5bVDc7wt7MEcdeFh1jc0oJYmIQpVB93OxjgigtMQyfo4e/ 8L8QVumcgaqoYecXySBZG/pMT6tf5ShxAYdnbOVY= From: Andre Muezerie To: Konstantin Ananyev Cc: dev@dpdk.org, Andre Muezerie Subject: [PATCH 01/21] app/test-acl: use portable variadic macros Date: Tue, 10 Dec 2024 18:05:31 -0800 Message-Id: <1733882751-29598-2-git-send-email-andremue@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1733882751-29598-1-git-send-email-andremue@linux.microsoft.com> References: <1733882751-29598-1-git-send-email-andremue@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Many places are using a GCC extension related to variadic macros, where a name prepends the ellipsis. This results in a warning like the one below when compiling the code with MSVC: app\test-pmd\testpmd.h(1314): error C2608: invalid token '...' in macro parameter list Variadic macros became a standard part of the C language with C99. GCC, Clang and MSVC handle them properly. The fix is to remove the prefix name (args... becomes ...) and use __VA_ARGS__. Signed-off-by: Andre Muezerie --- app/test-acl/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-acl/main.c b/app/test-acl/main.c index 41ce83db08..3a791b3ccf 100644 --- a/app/test-acl/main.c +++ b/app/test-acl/main.c @@ -423,9 +423,9 @@ static const char cb_port_delim[] = ":"; static char line[LINE_MAX]; -#define dump_verbose(lvl, fh, fmt, args...) do { \ +#define dump_verbose(lvl, fh, fmt, ...) do { \ if ((lvl) <= (int32_t)config.verbose) \ - fprintf(fh, fmt, ##args); \ + fprintf(fh, fmt, ##__VA_ARGS__); \ } while (0) -- 2.47.0.vfs.0.3