From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0605B45E7C; Wed, 11 Dec 2024 23:08:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE5E84066E; Wed, 11 Dec 2024 23:07:46 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 0ADD0402E3 for ; Wed, 11 Dec 2024 23:07:34 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id CDD4C2053682; Wed, 11 Dec 2024 14:07:32 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com CDD4C2053682 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1733954852; bh=GC5hZ5NDeikC+8B2hADgkMaPfAUrkxjKROMH7V6Dyj4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JIK/9MYagdOk1AzcQ126TnLD9ArKf7pl6GkJnzMX6M21IaQ/th+ak0+1k9QMK4Wdg pQUG60U1Vs36YpF0S1YOZGYtK/KZ1gSlZO+g+FzIi2c95vuDon+R7EjYg2holqzHM2 eT8KqgcEKXT1GW1nbc79M2HbuJDhbztdKJqFgLM4= From: Andre Muezerie To: dev@dpdk.org Cc: Andre Muezerie Subject: [PATCH v2 14/14] drivers/vdpa: use portable variadic macros Date: Wed, 11 Dec 2024 14:07:24 -0800 Message-Id: <1733954844-24397-15-git-send-email-andremue@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1733954844-24397-1-git-send-email-andremue@linux.microsoft.com> References: <1733882751-29598-1-git-send-email-andremue@linux.microsoft.com> <1733954844-24397-1-git-send-email-andremue@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Many places are using a GCC extension related to variadic macros, where a name prepends the ellipsis. This results in a warning like the one below when compiling the code with MSVC: app\test-pmd\testpmd.h(1314): error C2608: invalid token '...' in macro parameter list Variadic macros became a standard part of the C language with C99. GCC, Clang and MSVC handle them properly. The fix is to remove the prefix name (args... becomes ...) and use __VA_ARGS__. Signed-off-by: Andre Muezerie --- drivers/vdpa/ifc/base/ifcvf_osdep.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vdpa/ifc/base/ifcvf_osdep.h b/drivers/vdpa/ifc/base/ifcvf_osdep.h index ba7d684c25..bbbde153ee 100644 --- a/drivers/vdpa/ifc/base/ifcvf_osdep.h +++ b/drivers/vdpa/ifc/base/ifcvf_osdep.h @@ -16,8 +16,8 @@ extern int ifcvf_vdpa_logtype; #define RTE_LOGTYPE_IFCVF_VDPA ifcvf_vdpa_logtype -#define WARNINGOUT(S, args...) RTE_LOG(WARNING, IFCVF_VDPA, S, ##args) -#define DEBUGOUT(S, args...) RTE_LOG(DEBUG, IFCVF_VDPA, S, ##args) +#define WARNINGOUT(S, ...) RTE_LOG(WARNING, IFCVF_VDPA, S, ##__VA_ARGS__) +#define DEBUGOUT(S, ...) RTE_LOG(DEBUG, IFCVF_VDPA, S, ##__VA_ARGS__) #define STATIC static #define msec_delay(x) rte_delay_us_sleep(1000 * (x)) -- 2.47.0.vfs.0.3