From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 858F645E7C; Wed, 11 Dec 2024 23:08:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E30C4064A; Wed, 11 Dec 2024 23:07:40 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id DA891402A8 for ; Wed, 11 Dec 2024 23:07:33 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id 738AF204723A; Wed, 11 Dec 2024 14:07:32 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 738AF204723A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1733954852; bh=bI3pr7nU4qLOsE2B4Phqk+KOfgj9t0HEztH5qmDS5dw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pFSeCLtASvktXsnuNodHQeGkOT8ekCPFwv7afUH0uZx9Kgyx62iPgMq4NmyYzU0gn nLFi+HRmfdJcAMC6Nxp9n6RHHOhB4LGvYZEaqCwftVcNK9epEXTWNfZGLPrwE8zwk8 sVi+tskxy6mbA5fYqF/iyFKDiVN9DSYxcYMzm940= From: Andre Muezerie To: dev@dpdk.org Cc: Andre Muezerie Subject: [PATCH v2 07/14] drivers/compress: use portable variadic macros Date: Wed, 11 Dec 2024 14:07:17 -0800 Message-Id: <1733954844-24397-8-git-send-email-andremue@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1733954844-24397-1-git-send-email-andremue@linux.microsoft.com> References: <1733882751-29598-1-git-send-email-andremue@linux.microsoft.com> <1733954844-24397-1-git-send-email-andremue@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Many places are using a GCC extension related to variadic macros, where a name prepends the ellipsis. This results in a warning like the one below when compiling the code with MSVC: app\test-pmd\testpmd.h(1314): error C2608: invalid token '...' in macro parameter list Variadic macros became a standard part of the C language with C99. GCC, Clang and MSVC handle them properly. The fix is to remove the prefix name (args... becomes ...) and use __VA_ARGS__. Signed-off-by: Andre Muezerie --- drivers/compress/octeontx/otx_zip.h | 8 ++++---- drivers/compress/zlib/zlib_pmd_private.h | 12 ++++++------ 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/compress/octeontx/otx_zip.h b/drivers/compress/octeontx/otx_zip.h index bf09e2f58c..6265664ead 100644 --- a/drivers/compress/octeontx/otx_zip.h +++ b/drivers/compress/octeontx/otx_zip.h @@ -80,10 +80,10 @@ extern int octtx_zip_logtype_driver; #define ZIP_PMD_LOG(level, ...) \ RTE_LOG_LINE_PREFIX(level, OCTTX_ZIP_DRIVER, "%s(): ", __func__, __VA_ARGS__) -#define ZIP_PMD_INFO(fmt, args...) \ - ZIP_PMD_LOG(INFO, fmt, ## args) -#define ZIP_PMD_ERR(fmt, args...) \ - ZIP_PMD_LOG(ERR, fmt, ## args) +#define ZIP_PMD_INFO(fmt, ...) \ + ZIP_PMD_LOG(INFO, fmt, ## __VA_ARGS__) +#define ZIP_PMD_ERR(fmt, ...) \ + ZIP_PMD_LOG(ERR, fmt, ## __VA_ARGS__) /* resources required to process stream */ enum NUM_BUFS_PER_STREAM { diff --git a/drivers/compress/zlib/zlib_pmd_private.h b/drivers/compress/zlib/zlib_pmd_private.h index 7f6a57c6c5..fd8c4c55a4 100644 --- a/drivers/compress/zlib/zlib_pmd_private.h +++ b/drivers/compress/zlib/zlib_pmd_private.h @@ -19,12 +19,12 @@ extern int zlib_logtype_driver; #define ZLIB_PMD_LOG(level, ...) \ RTE_LOG_LINE_PREFIX(level, ZLIB_DRIVER, "%s(): ", __func__, __VA_ARGS__) -#define ZLIB_PMD_INFO(fmt, args...) \ - ZLIB_PMD_LOG(INFO, fmt, ## args) -#define ZLIB_PMD_ERR(fmt, args...) \ - ZLIB_PMD_LOG(ERR, fmt, ## args) -#define ZLIB_PMD_WARN(fmt, args...) \ - ZLIB_PMD_LOG(WARNING, fmt, ## args) +#define ZLIB_PMD_INFO(fmt, ...) \ + ZLIB_PMD_LOG(INFO, fmt, ## __VA_ARGS__) +#define ZLIB_PMD_ERR(fmt, ...) \ + ZLIB_PMD_LOG(ERR, fmt, ## __VA_ARGS__) +#define ZLIB_PMD_WARN(fmt, ...) \ + ZLIB_PMD_LOG(WARNING, fmt, ## __VA_ARGS__) struct zlib_private { struct rte_mempool *mp; -- 2.47.0.vfs.0.3