* [dpdk-dev] [PATCH 1/4] .gitignore: add section header comments
@ 2019-03-06 17:05 Bruce Richardson
2019-03-06 17:05 ` [dpdk-dev] [PATCH 2/4] .gitignore: ignore python bytecode files Bruce Richardson
` (3 more replies)
0 siblings, 4 replies; 15+ messages in thread
From: Bruce Richardson @ 2019-03-06 17:05 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson
Split the ignored file list into section based on logical groups of files,
putting a comment at the top of each section clarifying what it is.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
.gitignore | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.gitignore b/.gitignore
index 9105e26c5..b23e1dbb7 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,9 +1,12 @@
+# ignore generated documentation tables
doc/guides/nics/overview_table.txt
doc/guides/cryptodevs/overview_feature_table.txt
doc/guides/cryptodevs/overview_cipher_table.txt
doc/guides/cryptodevs/overview_auth_table.txt
doc/guides/cryptodevs/overview_aead_table.txt
doc/guides/compressdevs/overview_feature_table.txt
+
+# ignore generated ctags/cscope files
cscope.out.po
cscope.out.in
cscope.out
--
2.20.1
^ permalink raw reply [flat|nested] 15+ messages in thread* [dpdk-dev] [PATCH 2/4] .gitignore: ignore python bytecode files 2019-03-06 17:05 [dpdk-dev] [PATCH 1/4] .gitignore: add section header comments Bruce Richardson @ 2019-03-06 17:05 ` Bruce Richardson 2019-03-06 17:05 ` [dpdk-dev] [PATCH 3/4] .gitignore: ignore hidden files Bruce Richardson ` (2 subsequent siblings) 3 siblings, 0 replies; 15+ messages in thread From: Bruce Richardson @ 2019-03-06 17:05 UTC (permalink / raw) To: dev; +Cc: Bruce Richardson After you run a python script, a .pyc file is often left behind, which we don't want to track in git. Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index b23e1dbb7..eb3c23705 100644 --- a/.gitignore +++ b/.gitignore @@ -16,3 +16,6 @@ GPATH GRTAGS tags TAGS + +# ignore python bytecode files +*.pyc -- 2.20.1 ^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH 3/4] .gitignore: ignore hidden files 2019-03-06 17:05 [dpdk-dev] [PATCH 1/4] .gitignore: add section header comments Bruce Richardson 2019-03-06 17:05 ` [dpdk-dev] [PATCH 2/4] .gitignore: ignore python bytecode files Bruce Richardson @ 2019-03-06 17:05 ` Bruce Richardson 2019-03-06 17:05 ` [dpdk-dev] [PATCH 4/4] .gitignore: ignore build directories from test-meson-build Bruce Richardson 2019-03-11 10:57 ` [dpdk-dev] [PATCH v2 1/4] .gitignore: add section header comments Bruce Richardson 3 siblings, 0 replies; 15+ messages in thread From: Bruce Richardson @ 2019-03-06 17:05 UTC (permalink / raw) To: dev; +Cc: Bruce Richardson Generally hidden files are hidden for good reason and we don't want to track them in git. They can always be manually added to git tracking individually if needed. Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index eb3c23705..79509c35d 100644 --- a/.gitignore +++ b/.gitignore @@ -19,3 +19,6 @@ TAGS # ignore python bytecode files *.pyc + +# ignore hidden files +.* -- 2.20.1 ^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH 4/4] .gitignore: ignore build directories from test-meson-build 2019-03-06 17:05 [dpdk-dev] [PATCH 1/4] .gitignore: add section header comments Bruce Richardson 2019-03-06 17:05 ` [dpdk-dev] [PATCH 2/4] .gitignore: ignore python bytecode files Bruce Richardson 2019-03-06 17:05 ` [dpdk-dev] [PATCH 3/4] .gitignore: ignore hidden files Bruce Richardson @ 2019-03-06 17:05 ` Bruce Richardson 2019-03-09 0:47 ` Thomas Monjalon 2019-03-11 10:57 ` [dpdk-dev] [PATCH v2 1/4] .gitignore: add section header comments Bruce Richardson 3 siblings, 1 reply; 15+ messages in thread From: Bruce Richardson @ 2019-03-06 17:05 UTC (permalink / raw) To: dev; +Cc: Bruce Richardson test-meson-build.sh generates multiple build directories for various targets. As these follow a few known patterns of reasonable lengths, and since they don't need to be tracked in git, we can add them to the gitignore file. Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> --- .gitignore | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.gitignore b/.gitignore index 79509c35d..e10605c4b 100644 --- a/.gitignore +++ b/.gitignore @@ -22,3 +22,9 @@ TAGS # ignore hidden files .* + +# ignore build directories from test-meson-builds +build-arm64-* +build-clang-* +build-gcc-* +build-x86-default -- 2.20.1 ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH 4/4] .gitignore: ignore build directories from test-meson-build 2019-03-06 17:05 ` [dpdk-dev] [PATCH 4/4] .gitignore: ignore build directories from test-meson-build Bruce Richardson @ 2019-03-09 0:47 ` Thomas Monjalon 2019-03-09 3:03 ` Stephen Hemminger 0 siblings, 1 reply; 15+ messages in thread From: Thomas Monjalon @ 2019-03-09 0:47 UTC (permalink / raw) To: Bruce Richardson; +Cc: dev 06/03/2019 18:05, Bruce Richardson: > test-meson-build.sh generates multiple build directories for various > targets. As these follow a few known patterns of reasonable lengths, > and since they don't need to be tracked in git, we can add them to > the gitignore file. > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > --- > --- a/.gitignore > +++ b/.gitignore > +build-arm64-* > +build-clang-* > +build-gcc-* > +build-x86-default We could even ignore build-* ? ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH 4/4] .gitignore: ignore build directories from test-meson-build 2019-03-09 0:47 ` Thomas Monjalon @ 2019-03-09 3:03 ` Stephen Hemminger 2019-03-09 10:40 ` Thomas Monjalon 0 siblings, 1 reply; 15+ messages in thread From: Stephen Hemminger @ 2019-03-09 3:03 UTC (permalink / raw) To: Thomas Monjalon; +Cc: Bruce Richardson, dev On Sat, 09 Mar 2019 01:47:32 +0100 Thomas Monjalon <thomas@monjalon.net> wrote: > 06/03/2019 18:05, Bruce Richardson: > > test-meson-build.sh generates multiple build directories for various > > targets. As these follow a few known patterns of reasonable lengths, > > and since they don't need to be tracked in git, we can add them to > > the gitignore file. > > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > > --- > > --- a/.gitignore > > +++ b/.gitignore > > +build-arm64-* > > +build-clang-* > > +build-gcc-* > > +build-x86-default > > We could even ignore build-* ? > > Why not? build* Since the default build directory in build/ ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH 4/4] .gitignore: ignore build directories from test-meson-build 2019-03-09 3:03 ` Stephen Hemminger @ 2019-03-09 10:40 ` Thomas Monjalon 2019-03-09 13:32 ` Rami Rosen 0 siblings, 1 reply; 15+ messages in thread From: Thomas Monjalon @ 2019-03-09 10:40 UTC (permalink / raw) To: Stephen Hemminger; +Cc: Bruce Richardson, dev 09/03/2019 04:03, Stephen Hemminger: > On Sat, 09 Mar 2019 01:47:32 +0100 > Thomas Monjalon <thomas@monjalon.net> wrote: > > > 06/03/2019 18:05, Bruce Richardson: > > > test-meson-build.sh generates multiple build directories for various > > > targets. As these follow a few known patterns of reasonable lengths, > > > and since they don't need to be tracked in git, we can add them to > > > the gitignore file. > > > > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > > > --- > > > --- a/.gitignore > > > +++ b/.gitignore > > > +build-arm64-* > > > +build-clang-* > > > +build-gcc-* > > > +build-x86-default > > > > We could even ignore build-* ? > > Why not? > build* > > Since the default build directory in build/ Yes, but "git ls build*" is not empty because of buildtools/ Could be "build" and "build-*". ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH 4/4] .gitignore: ignore build directories from test-meson-build 2019-03-09 10:40 ` Thomas Monjalon @ 2019-03-09 13:32 ` Rami Rosen 2019-03-11 9:46 ` Bruce Richardson 0 siblings, 1 reply; 15+ messages in thread From: Rami Rosen @ 2019-03-09 13:32 UTC (permalink / raw) To: Thomas Monjalon; +Cc: stephen, Bruce Richardson, dev > Thomas Monjalon <thomas@monjalon.net> wrote: >Yes, but "git ls build*" is not empty because of buildtools/ >Could be "build" and "build-*". +1 > > > > > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH 4/4] .gitignore: ignore build directories from test-meson-build 2019-03-09 13:32 ` Rami Rosen @ 2019-03-11 9:46 ` Bruce Richardson 0 siblings, 0 replies; 15+ messages in thread From: Bruce Richardson @ 2019-03-11 9:46 UTC (permalink / raw) To: Rami Rosen; +Cc: Thomas Monjalon, stephen, dev On Sat, Mar 09, 2019 at 03:32:57PM +0200, Rami Rosen wrote: > > Thomas Monjalon <[1]thomas@monjalon.net> wrote: > >Yes, but "git ls build*" is not empty because of buildtools/ > >Could be "build" and "build-*". > +1 > Ok. I didn't want to be too liberal in my wildcarding hence the set I provided, but I'll do a V2 with this sorter version, since it makes sense and is unlikely to cause us issues. /Bruce ^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v2 1/4] .gitignore: add section header comments 2019-03-06 17:05 [dpdk-dev] [PATCH 1/4] .gitignore: add section header comments Bruce Richardson ` (2 preceding siblings ...) 2019-03-06 17:05 ` [dpdk-dev] [PATCH 4/4] .gitignore: ignore build directories from test-meson-build Bruce Richardson @ 2019-03-11 10:57 ` Bruce Richardson 2019-03-11 10:57 ` [dpdk-dev] [PATCH v2 2/4] .gitignore: ignore python bytecode files Bruce Richardson ` (3 more replies) 3 siblings, 4 replies; 15+ messages in thread From: Bruce Richardson @ 2019-03-11 10:57 UTC (permalink / raw) To: dev; +Cc: Stephen Hemminger, Thomas Monjalon, Rami Rosen, Bruce Richardson Split the ignored file list into section based on logical groups of files, putting a comment at the top of each section clarifying what it is. Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index 9105e26c5..b23e1dbb7 100644 --- a/.gitignore +++ b/.gitignore @@ -1,9 +1,12 @@ +# ignore generated documentation tables doc/guides/nics/overview_table.txt doc/guides/cryptodevs/overview_feature_table.txt doc/guides/cryptodevs/overview_cipher_table.txt doc/guides/cryptodevs/overview_auth_table.txt doc/guides/cryptodevs/overview_aead_table.txt doc/guides/compressdevs/overview_feature_table.txt + +# ignore generated ctags/cscope files cscope.out.po cscope.out.in cscope.out -- 2.20.1 ^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v2 2/4] .gitignore: ignore python bytecode files 2019-03-11 10:57 ` [dpdk-dev] [PATCH v2 1/4] .gitignore: add section header comments Bruce Richardson @ 2019-03-11 10:57 ` Bruce Richardson 2019-03-11 10:57 ` [dpdk-dev] [PATCH v2 3/4] .gitignore: ignore hidden files Bruce Richardson ` (2 subsequent siblings) 3 siblings, 0 replies; 15+ messages in thread From: Bruce Richardson @ 2019-03-11 10:57 UTC (permalink / raw) To: dev; +Cc: Stephen Hemminger, Thomas Monjalon, Rami Rosen, Bruce Richardson After you run a python script, a .pyc file is often left behind, which we don't want to track in git. Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index b23e1dbb7..eb3c23705 100644 --- a/.gitignore +++ b/.gitignore @@ -16,3 +16,6 @@ GPATH GRTAGS tags TAGS + +# ignore python bytecode files +*.pyc -- 2.20.1 ^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v2 3/4] .gitignore: ignore hidden files 2019-03-11 10:57 ` [dpdk-dev] [PATCH v2 1/4] .gitignore: add section header comments Bruce Richardson 2019-03-11 10:57 ` [dpdk-dev] [PATCH v2 2/4] .gitignore: ignore python bytecode files Bruce Richardson @ 2019-03-11 10:57 ` Bruce Richardson 2019-03-11 10:57 ` [dpdk-dev] [PATCH v2 4/4] .gitignore: ignore build directories Bruce Richardson 2019-03-13 10:57 ` [dpdk-dev] [PATCH v2 1/4] .gitignore: add section header comments Thomas Monjalon 3 siblings, 0 replies; 15+ messages in thread From: Bruce Richardson @ 2019-03-11 10:57 UTC (permalink / raw) To: dev; +Cc: Stephen Hemminger, Thomas Monjalon, Rami Rosen, Bruce Richardson Generally hidden files are hidden for good reason and we don't want to track them in git. They can always be manually added to git tracking individually if needed. Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index eb3c23705..79509c35d 100644 --- a/.gitignore +++ b/.gitignore @@ -19,3 +19,6 @@ TAGS # ignore python bytecode files *.pyc + +# ignore hidden files +.* -- 2.20.1 ^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v2 4/4] .gitignore: ignore build directories 2019-03-11 10:57 ` [dpdk-dev] [PATCH v2 1/4] .gitignore: add section header comments Bruce Richardson 2019-03-11 10:57 ` [dpdk-dev] [PATCH v2 2/4] .gitignore: ignore python bytecode files Bruce Richardson 2019-03-11 10:57 ` [dpdk-dev] [PATCH v2 3/4] .gitignore: ignore hidden files Bruce Richardson @ 2019-03-11 10:57 ` Bruce Richardson 2019-03-11 17:27 ` Rami Rosen 2019-03-13 10:57 ` [dpdk-dev] [PATCH v2 1/4] .gitignore: add section header comments Thomas Monjalon 3 siblings, 1 reply; 15+ messages in thread From: Bruce Richardson @ 2019-03-11 10:57 UTC (permalink / raw) To: dev; +Cc: Stephen Hemminger, Thomas Monjalon, Rami Rosen, Bruce Richardson test-meson-build.sh generates multiple build directories for various targets. As these follow a known pattern, and since they don't need to be tracked in git, we can add them to the gitignore file, along with the default build directory "build". Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> --- .gitignore | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.gitignore b/.gitignore index 79509c35d..73822ae5e 100644 --- a/.gitignore +++ b/.gitignore @@ -22,3 +22,7 @@ TAGS # ignore hidden files .* + +# ignore default build directory, and directories from test-meson-builds.sh +build +build-* -- 2.20.1 ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v2 4/4] .gitignore: ignore build directories 2019-03-11 10:57 ` [dpdk-dev] [PATCH v2 4/4] .gitignore: ignore build directories Bruce Richardson @ 2019-03-11 17:27 ` Rami Rosen 0 siblings, 0 replies; 15+ messages in thread From: Rami Rosen @ 2019-03-11 17:27 UTC (permalink / raw) To: Bruce Richardson; +Cc: dev, stephen, Thomas Monjalon Acked-by: Rami Rosen <ramirose@gmail.com> > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v2 1/4] .gitignore: add section header comments 2019-03-11 10:57 ` [dpdk-dev] [PATCH v2 1/4] .gitignore: add section header comments Bruce Richardson ` (2 preceding siblings ...) 2019-03-11 10:57 ` [dpdk-dev] [PATCH v2 4/4] .gitignore: ignore build directories Bruce Richardson @ 2019-03-13 10:57 ` Thomas Monjalon 3 siblings, 0 replies; 15+ messages in thread From: Thomas Monjalon @ 2019-03-13 10:57 UTC (permalink / raw) To: Bruce Richardson; +Cc: dev, Stephen Hemminger, Rami Rosen 11/03/2019 11:57, Bruce Richardson: > Split the ignored file list into section based on logical groups of files, > putting a comment at the top of each section clarifying what it is. > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> Series applied, thanks ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2019-03-13 10:57 UTC | newest] Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-03-06 17:05 [dpdk-dev] [PATCH 1/4] .gitignore: add section header comments Bruce Richardson 2019-03-06 17:05 ` [dpdk-dev] [PATCH 2/4] .gitignore: ignore python bytecode files Bruce Richardson 2019-03-06 17:05 ` [dpdk-dev] [PATCH 3/4] .gitignore: ignore hidden files Bruce Richardson 2019-03-06 17:05 ` [dpdk-dev] [PATCH 4/4] .gitignore: ignore build directories from test-meson-build Bruce Richardson 2019-03-09 0:47 ` Thomas Monjalon 2019-03-09 3:03 ` Stephen Hemminger 2019-03-09 10:40 ` Thomas Monjalon 2019-03-09 13:32 ` Rami Rosen 2019-03-11 9:46 ` Bruce Richardson 2019-03-11 10:57 ` [dpdk-dev] [PATCH v2 1/4] .gitignore: add section header comments Bruce Richardson 2019-03-11 10:57 ` [dpdk-dev] [PATCH v2 2/4] .gitignore: ignore python bytecode files Bruce Richardson 2019-03-11 10:57 ` [dpdk-dev] [PATCH v2 3/4] .gitignore: ignore hidden files Bruce Richardson 2019-03-11 10:57 ` [dpdk-dev] [PATCH v2 4/4] .gitignore: ignore build directories Bruce Richardson 2019-03-11 17:27 ` Rami Rosen 2019-03-13 10:57 ` [dpdk-dev] [PATCH v2 1/4] .gitignore: add section header comments Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).