From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E49C945F4E; Fri, 27 Dec 2024 00:15:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9231A402D6; Fri, 27 Dec 2024 00:14:57 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 6A3C240294 for ; Fri, 27 Dec 2024 00:14:54 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id 8F7E5203EC27; Thu, 26 Dec 2024 15:14:53 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8F7E5203EC27 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1735254893; bh=V9RS2NDe5KoGOAsD9CifG4pHots+1WwRn0nGFtkNjG8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C3B+y8//o792P1tFwaL4QoYenu5sscl7u1Er4CmrgT6MuZw+XpjedRuCMJi58DXtu R2g/wEWtkE/rtf23Zl6xJkWIDULSk7W7MbU6NtWzMT+1xRPBKLyROJ4jlDSODUNlUH vicOdLMKuSwCsHtD+HqFR05qIFbJ19TIIbzpg6zU= From: Andre Muezerie To: Bruce Richardson , Konstantin Ananyev , Jingjing Wu , Praveen Shetty Cc: dev@dpdk.org, Andre Muezerie Subject: [PATCH 1/2] drivers_common: fix void function returning a value Date: Thu, 26 Dec 2024 15:14:49 -0800 Message-Id: <1735254890-18457-2-git-send-email-andremue@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1735254890-18457-1-git-send-email-andremue@linux.microsoft.com> References: <1735254890-18457-1-git-send-email-andremue@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch avoids warnings like the one below emitted by MSVC: ../drivers/common/idpf/idpf_common_rxtx_avx512.c(139): warning C4098: 'idpf_singleq_rearm': 'void' function returning a value Signed-off-by: Andre Muezerie --- drivers/common/idpf/idpf_common_rxtx_avx512.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/common/idpf/idpf_common_rxtx_avx512.c b/drivers/common/idpf/idpf_common_rxtx_avx512.c index b8450b03ae..9ea71c3718 100644 --- a/drivers/common/idpf/idpf_common_rxtx_avx512.c +++ b/drivers/common/idpf/idpf_common_rxtx_avx512.c @@ -137,8 +137,10 @@ idpf_singleq_rearm(struct idpf_rx_queue *rxq) rxdp += rxq->rxrearm_start; - if (unlikely(cache == NULL)) - return idpf_singleq_rearm_common(rxq); + if (unlikely(cache == NULL)) { + idpf_singleq_rearm_common(rxq); + return; + } /* We need to pull 'n' more MBUFs into the software ring from mempool * We inline the mempool function here, so we can vectorize the copy @@ -607,8 +609,10 @@ idpf_splitq_rearm(struct idpf_rx_queue *rx_bufq) rxdp += rx_bufq->rxrearm_start; - if (unlikely(!cache)) - return idpf_splitq_rearm_common(rx_bufq); + if (unlikely(!cache)) { + idpf_splitq_rearm_common(rx_bufq); + return; + } /* We need to pull 'n' more MBUFs into the software ring from mempool * We inline the mempool function here, so we can vectorize the copy -- 2.47.0.vfs.0.3