From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com
 [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id AB45C377E
 for <dev@dpdk.org>; Wed, 16 Sep 2015 15:24:47 +0200 (CEST)
Received: by wiclk2 with SMTP id lk2so73082462wic.0
 for <dev@dpdk.org>; Wed, 16 Sep 2015 06:24:47 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=vvM7EncK41ceJw+IWVFHJ2967JMOos0hjklbRcoloLI=;
 b=Fa75IOXHGhY16heHg6YNJr4k4A/GO4hEERlPReE4HTEPO6cyBJtQ1fgyFMDq+a8jXd
 Zqz9Y+jgNww4mUnhpgP4oqlZlCAy1KvE+4iwI2WT60qpQdZqBKhyI/AzHgMP/lZMfXPB
 1pR2fbttbNQ/Sf7o4LiZXKOb5z1sWp6OqVMBk6ZcCzG6LzMdX5/asSloD3/uCJatNbkT
 CgwRECiwkDUVzAUnxMSOmFhS/AqpP4JMkp/1zQ01i6NJ/TQ81+NYMcHZJ1Fsq4eKqwmG
 Qc4wTWAQZLobZh9P5R9OkP9tnfqOVWpdrAJzodMgGXUNImi3Bodbe/i20bw2Y4BZOBL6
 aWVg==
X-Gm-Message-State: ALoCoQknvMbEpd3Xc/XVVPG9N7s6dY01maRFTA+e9GG/lA07rjHJN76N9KyGZCUi1tLWgdYsS8o6
X-Received: by 10.180.8.132 with SMTP id r4mr19602902wia.70.1442409887546;
 Wed, 16 Sep 2015 06:24:47 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id bh5sm26590624wjb.42.2015.09.16.06.24.46
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 16 Sep 2015 06:24:46 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Remy Horton <remy.horton@intel.com>
Date: Wed, 16 Sep 2015 15:23:39 +0200
Message-ID: <1735667.JZ2y0EAyYG@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1442408865-7569-1-git-send-email-remy.horton@intel.com>
References: <1442408865-7569-1-git-send-email-remy.horton@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ixgbe: Out-by-one in get/set EEPROM
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Sep 2015 13:24:47 -0000

2015-09-16 14:07, Remy Horton:
> Incorrect operator in ixgbe_get_eeprom & ixgbe_set_eeprom prevents
> last byte of EEPROM being read/written, and hence cannot be dumped
> or updated in entirity using these functions.

This explanation is good but the title is not clear enough. It should
start with "ixgbe: fix". Fix what? I'd say "fix access to last byte of EEPROM".
Then creating a commit starting with "fix" should trigger 2 other things:
	- a Fixes: tag
	- an update in the release notes (because the bug exists in previous releases)

Thanks