From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Zhou, Danny" <danny.zhou@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 2/5] ixgbe: enable rx queue interrupts for both PF and VF
Date: Mon, 23 Feb 2015 14:20:27 +0100 [thread overview]
Message-ID: <1735949.6aPZLmAlBh@xps13> (raw)
In-Reply-To: <DFDF335405C17848924A094BC35766CF0AAB3513@SHSMSX104.ccr.corp.intel.com>
2015-02-23 11:23, Zhou, Danny:
> I noticed the V4 patch conflicts with the latest code on the main branch due to lots of code merged, and it
> is mentioned by Jun Xu in previous email, and I will have to rebase the patch and send out V5 version.
Maybe you misunderstood my comment.
I'm quoting an usage in patch 2 of max_intr which is defined in patch 4.
You have to better split and order your patches to make them compilable
and not break git bisect.
Thanks
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > Sent: Monday, February 23, 2015 7:20 PM
> > To: Zhou, Danny
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v4 2/5] ixgbe: enable rx queue interrupts for both PF and VF
> >
> > 2015-02-19 21:48, Zhou Danny:
> > > + /* set max interrupt vfio request */
> > > + pci_dev->intr_handle.max_intr = hw->mac.max_rx_queues +
> > > + IXGBE_MAX_OTHER_INTR;
> > > +
> >
> > Compilation is broken here.
next prev parent reply other threads:[~2015-02-23 13:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 13:48 [dpdk-dev] [PATCH v4 0/5] Interrupt mode PMD Zhou Danny
2015-02-19 13:48 ` [dpdk-dev] [PATCH v4 1/5] ethdev: add rx interrupt enable/disable functions Zhou Danny
2015-02-19 13:48 ` [dpdk-dev] [PATCH v4 2/5] ixgbe: enable rx queue interrupts for both PF and VF Zhou Danny
2015-02-23 11:19 ` Thomas Monjalon
2015-02-23 11:23 ` Zhou, Danny
2015-02-23 13:20 ` Thomas Monjalon [this message]
2015-02-23 15:11 ` Zhou, Danny
2015-02-19 13:48 ` [dpdk-dev] [PATCH v4 3/5] igb: enable rx queue interrupts for PF Zhou Danny
2015-02-19 13:48 ` [dpdk-dev] [PATCH v4 4/5] eal: add per rx queue interrupt handling based on VFIO Zhou Danny
2015-02-20 22:43 ` Thomas Monjalon
2015-02-23 11:47 ` Zhou, Danny
2015-02-23 13:28 ` Thomas Monjalon
2015-02-23 15:02 ` Zhou, Danny
2015-02-23 15:19 ` Thomas Monjalon
2015-02-23 15:24 ` Zhou, Danny
2015-02-21 2:56 ` Jun Xiao
2015-02-23 11:23 ` Zhou, Danny
2015-02-19 13:48 ` [dpdk-dev] [PATCH v4 5/5] l3fwd-power: enable one-shot rx interrupt and polling/interrupt mode switch Zhou Danny
2015-02-20 8:50 ` [dpdk-dev] [PATCH v4 0/5] Interrupt mode PMD Gonzalez Monroy, Sergio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1735949.6aPZLmAlBh@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=danny.zhou@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).