From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 722ACADD4 for ; Mon, 23 Feb 2015 14:20:58 +0100 (CET) Received: by mail-wi0-f180.google.com with SMTP id h11so16675713wiw.1 for ; Mon, 23 Feb 2015 05:20:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=qjjMot/qotd21l0u9BQrqYFLLUyoufPJXw8s/DGHyd0=; b=HG7TdeXsbpRKz6qOrNYoESspEOG2JaqyPcNbhQV55vdSDkbhmAlyrBW5R5wH+sJoxO eog/9GVXNZSktILrZuh+X7vxMNwj4WMXW4neJqeuiEWIa/MeUOnnJquAxarU/iH6P7I3 NfJVhHL4OUUz08PRt0Zh8q8NYbrFx7T9M1DciSbWe49dVPmJuQXfbFJ1Fmk+DaCgiQn9 vMu0XoKrcBfU2YvznyuYiR6kbzzWxt8xAZPsddyH3JOuRnrN+JkF1P13lKqBHFl/i7Z2 pC1hFjcz2WgplIvKusksYjAsDdbstK1tcYEdo5kOMNoIkYc6qIQgtQISSqimPujh/ssJ TMxA== X-Gm-Message-State: ALoCoQkYiOZ7khwhU5yOXumF3vVx60d5pLnttbmuFWKXW0MoshJ8lVkMDkdg/NSbBUCK460GilFH X-Received: by 10.194.242.6 with SMTP id wm6mr21791097wjc.7.1424697658137; Mon, 23 Feb 2015 05:20:58 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id l4sm15869926wiw.9.2015.02.23.05.20.56 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Feb 2015 05:20:57 -0800 (PST) From: Thomas Monjalon To: "Zhou, Danny" Date: Mon, 23 Feb 2015 14:20:27 +0100 Message-ID: <1735949.6aPZLmAlBh@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: References: <1424353698-29837-1-git-send-email-danny.zhou@intel.com> <4552356.3plUBHddm1@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 2/5] ixgbe: enable rx queue interrupts for both PF and VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Feb 2015 13:20:58 -0000 2015-02-23 11:23, Zhou, Danny: > I noticed the V4 patch conflicts with the latest code on the main branch due to lots of code merged, and it > is mentioned by Jun Xu in previous email, and I will have to rebase the patch and send out V5 version. Maybe you misunderstood my comment. I'm quoting an usage in patch 2 of max_intr which is defined in patch 4. You have to better split and order your patches to make them compilable and not break git bisect. Thanks > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Monday, February 23, 2015 7:20 PM > > To: Zhou, Danny > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v4 2/5] ixgbe: enable rx queue interrupts for both PF and VF > > > > 2015-02-19 21:48, Zhou Danny: > > > + /* set max interrupt vfio request */ > > > + pci_dev->intr_handle.max_intr = hw->mac.max_rx_queues + > > > + IXGBE_MAX_OTHER_INTR; > > > + > > > > Compilation is broken here.