From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 9B92F46024;
Thu, 9 Jan 2025 01:52:03 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 89B6C40677;
Thu, 9 Jan 2025 01:48:58 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
by mails.dpdk.org (Postfix) with ESMTP id E0021402EA
for <dev@dpdk.org>; Thu, 9 Jan 2025 01:48:41 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1213)
id 5AEFD203E3B8; Wed, 8 Jan 2025 16:48:40 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5AEFD203E3B8
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
s=default; t=1736383720;
bh=xawY6uwqaiTgLSzxd4j7C/JJR54SUNuMPKodc5TLMBw=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=A5iOf+6MVzgd5/9bHlq/ePanVmFRjXdnCBMhGyft5oaYx9INJZj2aMDqHNTNkzGry
iQxuOmmQwjOA4QSJPtqenyQZUhiITTWsC0cJax0ED9zpqatSGnPET92xp7QoU+Yfnf
9uYOGJiAywU54aAwrLFlFIb4Tue4iWOTPI5P6b90=
From: Andre Muezerie <andremue@linux.microsoft.com>
To: roretzla@linux.microsoft.com
Cc: aman.deep.singh@intel.com, anatoly.burakov@intel.com,
bruce.richardson@intel.com, byron.marohn@intel.com, conor.walsh@intel.com,
cristian.dumitrescu@intel.com, david.hunt@intel.com, dev@dpdk.org,
dsosnowski@nvidia.com, gakhil@marvell.com, jerinj@marvell.com,
jingjing.wu@intel.com, kirill.rybalchenko@intel.com,
konstantin.v.ananyev@yandex.ru, matan@nvidia.com, mb@smartsharesystems.com,
orika@nvidia.com, radu.nicolau@intel.com, ruifeng.wang@arm.com,
sameh.gobriel@intel.com, sivaprasad.tummala@amd.com, skori@marvell.com,
stephen@networkplumber.org, suanmingm@nvidia.com, vattunuru@marvell.com,
viacheslavo@nvidia.com, vladimir.medvedkin@intel.com,
yipeng1.wang@intel.com, Andre Muezerie <andremue@linux.microsoft.com>
Subject: [PATCH v9 11/30] drivers/dma: replace packed attributes
Date: Wed, 8 Jan 2025 16:48:16 -0800
Message-Id: <1736383715-31703-12-git-send-email-andremue@linux.microsoft.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1736383715-31703-1-git-send-email-andremue@linux.microsoft.com>
References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com>
<1736383715-31703-1-git-send-email-andremue@linux.microsoft.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
MSVC struct packing is not compatible with GCC. Replace macro
__rte_packed with __rte_packed_begin to push existing pack value
and set packing to 1-byte and macro __rte_packed_end to restore
the pack value prior to the push.
Macro __rte_packed_end is deliberately utilized to trigger a
MSVC compiler warning if no existing packing has been pushed allowing
easy identification of locations where the __rte_packed_begin is
missing.
Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
Reviewed-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
drivers/dma/dpaa/dpaa_qdma.h | 20 ++++++++++----------
drivers/dma/dpaa2/dpaa2_qdma.h | 16 ++++++++--------
drivers/dma/ioat/ioat_hw_defs.h | 4 ++--
3 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers/dma/dpaa/dpaa_qdma.h b/drivers/dma/dpaa/dpaa_qdma.h
index 91eaf1455a..0b08909221 100644
--- a/drivers/dma/dpaa/dpaa_qdma.h
+++ b/drivers/dma/dpaa/dpaa_qdma.h
@@ -119,7 +119,7 @@
(((fsl_qdma_engine)->block_offset) * (x))
/* qDMA Command Descriptor Formats */
-struct fsl_qdma_comp_cmd_desc {
+struct __rte_packed_begin fsl_qdma_comp_cmd_desc {
uint8_t status;
uint32_t rsv0:22;
uint32_t ser:1;
@@ -132,9 +132,9 @@ struct fsl_qdma_comp_cmd_desc {
uint8_t queue:3;
uint8_t rsv4:3;
uint8_t dd:2;
-} __rte_packed;
+} __rte_packed_end;
-struct fsl_qdma_comp_sg_desc {
+struct __rte_packed_begin fsl_qdma_comp_sg_desc {
uint32_t offset:13;
uint32_t rsv0:19;
uint32_t length:30;
@@ -143,9 +143,9 @@ struct fsl_qdma_comp_sg_desc {
uint32_t addr_lo;
uint8_t addr_hi;
uint32_t rsv1:24;
-} __rte_packed;
+} __rte_packed_end;
-struct fsl_qdma_sdf {
+struct __rte_packed_begin fsl_qdma_sdf {
uint32_t rsv0;
uint32_t ssd:12;
uint32_t sss:12;
@@ -160,9 +160,9 @@ struct fsl_qdma_sdf {
uint32_t sqos:3;
uint32_t ns:1;
uint32_t srttype:4;
-} __rte_packed;
+} __rte_packed_end;
-struct fsl_qdma_ddf {
+struct __rte_packed_begin fsl_qdma_ddf {
uint32_t rsv0;
uint32_t dsd:12;
uint32_t dss:12;
@@ -177,7 +177,7 @@ struct fsl_qdma_ddf {
uint32_t dqos:3;
uint32_t ns:1;
uint32_t dwttype:4;
-} __rte_packed;
+} __rte_packed_end;
struct fsl_qdma_df {
struct fsl_qdma_sdf sdf;
@@ -186,7 +186,7 @@ struct fsl_qdma_df {
#define FSL_QDMA_SG_MAX_ENTRY 64
#define FSL_QDMA_MAX_DESC_NUM (FSL_QDMA_SG_MAX_ENTRY * QDMA_QUEUE_SIZE)
-struct fsl_qdma_cmpd_ft {
+struct __rte_packed_begin fsl_qdma_cmpd_ft {
struct fsl_qdma_comp_sg_desc desc_buf;
struct fsl_qdma_comp_sg_desc desc_sbuf;
struct fsl_qdma_comp_sg_desc desc_dbuf;
@@ -197,7 +197,7 @@ struct fsl_qdma_cmpd_ft {
uint64_t phy_ssge;
uint64_t phy_dsge;
uint64_t phy_df;
-} __rte_packed;
+} __rte_packed_end;
#define FSL_QDMA_ERR_REG_STATUS_OFFSET 0xe00
diff --git a/drivers/dma/dpaa2/dpaa2_qdma.h b/drivers/dma/dpaa2/dpaa2_qdma.h
index 0fd1debaf8..e2d2eb4fa8 100644
--- a/drivers/dma/dpaa2/dpaa2_qdma.h
+++ b/drivers/dma/dpaa2/dpaa2_qdma.h
@@ -39,7 +39,7 @@
#define DPAA2_QDMA_BMT_DISABLE 0x0
/** Source/Destination Descriptor */
-struct qdma_sdd {
+struct __rte_packed_begin qdma_sdd {
uint32_t rsv;
/** Stride configuration */
uint32_t stride;
@@ -85,7 +85,7 @@ struct qdma_sdd {
uint32_t wrttype:4;
} write_cmd;
};
-} __rte_packed;
+} __rte_packed_end;
#define QDMA_SG_FMT_SDB 0x0 /* single data buffer */
#define QDMA_SG_FMT_FDS 0x1 /* frame data section */
@@ -96,7 +96,7 @@ struct qdma_sdd {
#define QDMA_SG_BMT_ENABLE DPAA2_QDMA_BMT_ENABLE
#define QDMA_SG_BMT_DISABLE DPAA2_QDMA_BMT_DISABLE
-struct qdma_sg_entry {
+struct __rte_packed_begin qdma_sg_entry {
uint32_t addr_lo; /* address 0:31 */
uint32_t addr_hi:17; /* address 32:48 */
uint32_t rsv:15;
@@ -122,7 +122,7 @@ struct qdma_sg_entry {
uint32_t f:1;
} ctrl;
};
-} __rte_packed;
+} __rte_packed_end;
struct dpaa2_qdma_rbp {
uint32_t use_ultrashort:1;
@@ -213,19 +213,19 @@ enum {
DPAA2_QDMA_MAX_SDD
};
-struct qdma_cntx_fle_sdd {
+struct __rte_packed_begin qdma_cntx_fle_sdd {
struct qbman_fle fle[DPAA2_QDMA_MAX_FLE];
struct qdma_sdd sdd[DPAA2_QDMA_MAX_SDD];
-} __rte_packed;
+} __rte_packed_end;
-struct qdma_cntx_sg {
+struct __rte_packed_begin qdma_cntx_sg {
struct qdma_cntx_fle_sdd fle_sdd;
struct qdma_sg_entry sg_src_entry[RTE_DPAAX_QDMA_JOB_SUBMIT_MAX];
struct qdma_sg_entry sg_dst_entry[RTE_DPAAX_QDMA_JOB_SUBMIT_MAX];
uint16_t cntx_idx[RTE_DPAAX_QDMA_JOB_SUBMIT_MAX];
uint16_t job_nb;
uint16_t rsv[3];
-} __rte_packed;
+} __rte_packed_end;
#define DPAA2_QDMA_IDXADDR_FROM_SG_FLAG(flag) \
((void *)(uintptr_t)((flag) - ((flag) & RTE_DPAAX_QDMA_SG_IDX_ADDR_MASK)))
diff --git a/drivers/dma/ioat/ioat_hw_defs.h b/drivers/dma/ioat/ioat_hw_defs.h
index 11893951f2..dbfbc50f70 100644
--- a/drivers/dma/ioat/ioat_hw_defs.h
+++ b/drivers/dma/ioat/ioat_hw_defs.h
@@ -52,7 +52,7 @@ extern "C" {
#define IOAT_DMACAP_PQ (1 << 9)
#define IOAT_DMACAP_DMA_DIF (1 << 10)
-struct ioat_registers {
+struct __rte_packed_begin ioat_registers {
uint8_t chancnt;
uint8_t xfercap;
uint8_t genctrl;
@@ -75,7 +75,7 @@ struct ioat_registers {
uint8_t reserved2[0x8]; /* 0xA0 */
uint32_t chanerr; /* 0xA8 */
uint32_t chanerrmask; /* 0xAC */
-} __rte_packed;
+} __rte_packed_end;
#define IOAT_CHANCMD_RESET 0x20
#define IOAT_CHANCMD_SUSPEND 0x04
--
2.47.0.vfs.0.3