From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 6431D46025;
	Thu,  9 Jan 2025 03:48:10 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 3224B40B94;
	Thu,  9 Jan 2025 03:46:45 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 1ED704025E
 for <dev@dpdk.org>; Thu,  9 Jan 2025 03:46:23 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1213)
 id 9623D206AB76; Wed,  8 Jan 2025 18:46:20 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 9623D206AB76
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1736390781;
 bh=jrkmCR6D7vL8KIKXQgV9d6JjxLhZ/DF065/RAICNMUU=;
 h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
 b=ocTKDEyK0CxMXR/3U+k27DIWMUwv4bCqaLNM9ZzsPqAG3StO+ai7g07SbgVtDVIgn
 odwNJ1p7TRRylQfY40Tq7IZpUxPOCOZ3A/LHP3uZMsVYKVxFJeYB3tJWMlSD2cV6Q4
 E+iM1nB8bumng1ApAUjfjtU/dZtC7cr7Y8d5fbzI=
From: Andre Muezerie <andremue@linux.microsoft.com>
To: roretzla@linux.microsoft.com
Cc: aman.deep.singh@intel.com, anatoly.burakov@intel.com,
 bruce.richardson@intel.com, byron.marohn@intel.com, conor.walsh@intel.com,
 cristian.dumitrescu@intel.com, david.hunt@intel.com, dev@dpdk.org,
 dsosnowski@nvidia.com, gakhil@marvell.com, jerinj@marvell.com,
 jingjing.wu@intel.com, kirill.rybalchenko@intel.com,
 konstantin.v.ananyev@yandex.ru, matan@nvidia.com, mb@smartsharesystems.com,
 orika@nvidia.com, radu.nicolau@intel.com, ruifeng.wang@arm.com,
 sameh.gobriel@intel.com, sivaprasad.tummala@amd.com, skori@marvell.com,
 stephen@networkplumber.org, suanmingm@nvidia.com, vattunuru@marvell.com,
 viacheslavo@nvidia.com, vladimir.medvedkin@intel.com,
 yipeng1.wang@intel.com, Andre Muezerie <andremue@linux.microsoft.com>
Subject: [PATCH v10 20/30] examples/ipsec_secgw: replace packed attributes
Date: Wed,  8 Jan 2025 18:46:04 -0800
Message-Id: <1736390774-14887-21-git-send-email-andremue@linux.microsoft.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1736390774-14887-1-git-send-email-andremue@linux.microsoft.com>
References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com>
 <1736390774-14887-1-git-send-email-andremue@linux.microsoft.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

MSVC struct packing is not compatible with GCC. Replace macro
__rte_packed with __rte_packed_begin to push existing pack value
and set packing to 1-byte and macro __rte_packed_end to restore
the pack value prior to the push.

Macro __rte_packed_end is deliberately utilized to trigger a
MSVC compiler warning if no existing packing has been pushed allowing
easy identification of locations where the __rte_packed_begin is
missing.

Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
 examples/ipsec-secgw/ipsec.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/examples/ipsec-secgw/ipsec.h b/examples/ipsec-secgw/ipsec.h
index f12f57e2d5..e3cc43ef3b 100644
--- a/examples/ipsec-secgw/ipsec.h
+++ b/examples/ipsec-secgw/ipsec.h
@@ -274,11 +274,11 @@ struct socket_ctx {
 	struct rte_mempool *session_pool;
 };
 
-struct cnt_blk {
+struct __rte_packed_begin cnt_blk {
 	uint32_t salt;
 	uint64_t iv;
 	uint32_t cnt;
-} __rte_packed;
+} __rte_packed_end;
 
 struct __rte_cache_aligned lcore_rx_queue {
 	uint16_t port_id;
-- 
2.47.0.vfs.0.3