From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 8F58246025;
Thu, 9 Jan 2025 03:48:20 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id ADCB240B99;
Thu, 9 Jan 2025 03:46:47 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
by mails.dpdk.org (Postfix) with ESMTP id 289314042E
for <dev@dpdk.org>; Thu, 9 Jan 2025 03:46:23 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1213)
id 239FE238AF4D; Wed, 8 Jan 2025 18:46:20 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 239FE238AF4D
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
s=default; t=1736390782;
bh=XVSSHll9pWvEgTmlWzf1W//81Lf2K3VtnWzUTpxisYc=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=TLo3ET/+YJXzrEztSFL1S0lMlrnrOpgSbeI5nbYBmYmfMdWY7rmCoVKKm5hNiXPB6
G2REiY25agZA/UVTnwrEjGNyPlVG5cK/29MARY9dP82WVwLYbVieDiwbsxO5hvpC37
uJUBDHuxncr49uaPejdH4xUN9fm4iVJvOajSCqHo=
From: Andre Muezerie <andremue@linux.microsoft.com>
To: roretzla@linux.microsoft.com
Cc: aman.deep.singh@intel.com, anatoly.burakov@intel.com,
bruce.richardson@intel.com, byron.marohn@intel.com, conor.walsh@intel.com,
cristian.dumitrescu@intel.com, david.hunt@intel.com, dev@dpdk.org,
dsosnowski@nvidia.com, gakhil@marvell.com, jerinj@marvell.com,
jingjing.wu@intel.com, kirill.rybalchenko@intel.com,
konstantin.v.ananyev@yandex.ru, matan@nvidia.com, mb@smartsharesystems.com,
orika@nvidia.com, radu.nicolau@intel.com, ruifeng.wang@arm.com,
sameh.gobriel@intel.com, sivaprasad.tummala@amd.com, skori@marvell.com,
stephen@networkplumber.org, suanmingm@nvidia.com, vattunuru@marvell.com,
viacheslavo@nvidia.com, vladimir.medvedkin@intel.com,
yipeng1.wang@intel.com, Andre Muezerie <andremue@linux.microsoft.com>
Subject: [PATCH v10 29/30] lib/vhost: replace packed attributes
Date: Wed, 8 Jan 2025 18:46:13 -0800
Message-Id: <1736390774-14887-30-git-send-email-andremue@linux.microsoft.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1736390774-14887-1-git-send-email-andremue@linux.microsoft.com>
References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com>
<1736390774-14887-1-git-send-email-andremue@linux.microsoft.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
MSVC struct packing is not compatible with GCC. Replace macro
__rte_packed with __rte_packed_begin to push existing pack value
and set packing to 1-byte and macro __rte_packed_end to restore
the pack value prior to the push.
Macro __rte_packed_end is deliberately utilized to trigger a
MSVC compiler warning if no existing packing has been pushed allowing
easy identification of locations where the __rte_packed_begin is
missing.
Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
lib/vhost/vhost_user.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/vhost/vhost_user.h b/lib/vhost/vhost_user.h
index edf7adb3c0..9a905ee5f4 100644
--- a/lib/vhost/vhost_user.h
+++ b/lib/vhost/vhost_user.h
@@ -143,7 +143,7 @@ struct vhost_user_config {
uint8_t region[VHOST_USER_MAX_CONFIG_SIZE];
};
-typedef struct VhostUserMsg {
+typedef struct __rte_packed_begin VhostUserMsg {
union {
uint32_t frontend; /* a VhostUserRequest value */
uint32_t backend; /* a VhostUserBackendRequest value*/
@@ -169,16 +169,16 @@ typedef struct VhostUserMsg {
struct vhost_user_config cfg;
} payload;
/* Nothing should be added after the payload */
-} __rte_packed VhostUserMsg;
+} __rte_packed_end VhostUserMsg;
/* Note: this structure and VhostUserMsg can't be changed carelessly as
* external message handlers rely on them.
*/
-struct __rte_packed vhu_msg_context {
+struct __rte_packed_begin vhu_msg_context {
VhostUserMsg msg;
int fds[VHOST_MEMORY_MAX_NREGIONS];
int fd_num;
-};
+} __rte_packed_end;
#define VHOST_USER_HDR_SIZE offsetof(VhostUserMsg, payload.u64)
--
2.47.0.vfs.0.3