From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id DE1DE4605F;
Fri, 10 Jan 2025 21:30:52 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 6CB2142E72;
Fri, 10 Jan 2025 21:25:35 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
by mails.dpdk.org (Postfix) with ESMTP id 0B34042D27
for <dev@dpdk.org>; Fri, 10 Jan 2025 21:24:03 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1213)
id BB2282059197; Fri, 10 Jan 2025 12:24:00 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com BB2282059197
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
s=default; t=1736540642;
bh=q9TAI8basnv28GMKZZCbcb124jQ8WYAl6I3fQK6xaGE=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=EstSoNYlBcvgBhpb3+055gcH7UvpVVNFSTyhOXrJS7EKq2gHNxtIPipUGs4ZlLw6O
/883EuvcgicDJdR23WvV+FZCxUCorNtru9VSLg8n/Tloq0c0YJoO1Oc6Ts9UT5SwY3
Y9S9mWJmvbGL7CRigA9UMSo7iMpXoJTMceRslnw0=
From: Andre Muezerie <andremue@linux.microsoft.com>
To: dev@dpdk.org
Cc: konstantin.ananyev@huawei.com, homas@monjalon.net,
david.marchand@redhat.com, Andre Muezerie <andremue@linux.microsoft.com>
Subject: [PATCH v14 73/81] drivers/common: add compile warning about use of
VLAs
Date: Fri, 10 Jan 2025 12:23:32 -0800
Message-Id: <1736540620-21764-74-git-send-email-andremue@linux.microsoft.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1736540620-21764-1-git-send-email-andremue@linux.microsoft.com>
References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>
<1736540620-21764-1-git-send-email-andremue@linux.microsoft.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
MSVC does not support VLAs, so we want to prevent VLAs from being
introduced under this path.
Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
drivers/common/mlx5/meson.build | 1 +
drivers/common/nfp/meson.build | 8 ++++++++
drivers/common/nitrox/meson.build | 8 ++++++++
drivers/common/qat/meson.build | 8 ++++++++
drivers/common/sfc_efx/meson.build | 1 +
5 files changed, 26 insertions(+)
diff --git a/drivers/common/mlx5/meson.build b/drivers/common/mlx5/meson.build
index 1eefc02f06..a6a67fbb85 100644
--- a/drivers/common/mlx5/meson.build
+++ b/drivers/common/mlx5/meson.build
@@ -26,6 +26,7 @@ sources += files(
cflags_options = [
'-std=c11',
+ '-Wvla',
'-Wno-strict-prototypes',
'-D_BSD_SOURCE',
'-D_DEFAULT_SOURCE',
diff --git a/drivers/common/nfp/meson.build b/drivers/common/nfp/meson.build
index a09d1e25e2..165be4a868 100644
--- a/drivers/common/nfp/meson.build
+++ b/drivers/common/nfp/meson.build
@@ -14,3 +14,11 @@ sources = files(
)
deps += ['bus_pci', 'net']
+
+extra_flags = ['-Wvla']
+
+foreach arg: extra_flags
+ if cc.has_argument(arg)
+ cflags += arg
+ endif
+endforeach
diff --git a/drivers/common/nitrox/meson.build b/drivers/common/nitrox/meson.build
index f3cb42f006..46cd8ba65c 100644
--- a/drivers/common/nitrox/meson.build
+++ b/drivers/common/nitrox/meson.build
@@ -17,3 +17,11 @@ sources += files(
includes += include_directories('../../crypto/nitrox')
includes += include_directories('../../compress/nitrox')
+
+extra_flags = ['-Wvla']
+
+foreach arg: extra_flags
+ if cc.has_argument(arg)
+ cflags += arg
+ endif
+endforeach
diff --git a/drivers/common/qat/meson.build b/drivers/common/qat/meson.build
index 5a8de16fe0..8dd38e9abd 100644
--- a/drivers/common/qat/meson.build
+++ b/drivers/common/qat/meson.build
@@ -119,3 +119,11 @@ if qat_crypto
deps += ['security']
cflags += ['-DBUILD_QAT_SYM', '-DBUILD_QAT_ASYM']
endif
+
+extra_flags = ['-Wvla']
+
+foreach arg: extra_flags
+ if cc.has_argument(arg)
+ cflags += arg
+ endif
+endforeach
diff --git a/drivers/common/sfc_efx/meson.build b/drivers/common/sfc_efx/meson.build
index 0cf0a23bf8..e3b90f670a 100644
--- a/drivers/common/sfc_efx/meson.build
+++ b/drivers/common/sfc_efx/meson.build
@@ -26,6 +26,7 @@ extra_flags += [
extra_flags += [
'-Waggregate-return',
'-Wbad-function-cast',
+ '-Wvla',
]
foreach flag: extra_flags
--
2.47.0.vfs.0.3