From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBA7846022; Fri, 10 Jan 2025 23:18:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C598240B91; Fri, 10 Jan 2025 23:17:14 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 7EFD3402DC for ; Fri, 10 Jan 2025 23:16:59 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id 1A9ED203D5FF; Fri, 10 Jan 2025 14:16:57 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1A9ED203D5FF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1736547418; bh=OMjUkDJWLLCLZVE+emaieYOMb608HhjkqHEQ19Dql2g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OW0iVKE5cBxvJ7xulimEJ5g/h9+MCvxs5kYiCjaKBhIySlGOtslokt9QWJAJsyLCV 4Z9NaPUSSszVU9iYsuTEfCf92J3J5vRRGSWrTE2Ar6HjTKzWPfqZ6l9VJIf2K3VzY3 bJLEg0EPHt/JhL7I7jSgYkCsNLlCghriE3YeUcBo= From: Andre Muezerie To: roretzla@linux.microsoft.com Cc: aman.deep.singh@intel.com, anatoly.burakov@intel.com, bruce.richardson@intel.com, byron.marohn@intel.com, conor.walsh@intel.com, cristian.dumitrescu@intel.com, david.hunt@intel.com, dev@dpdk.org, dsosnowski@nvidia.com, gakhil@marvell.com, jerinj@marvell.com, jingjing.wu@intel.com, kirill.rybalchenko@intel.com, konstantin.v.ananyev@yandex.ru, matan@nvidia.com, mb@smartsharesystems.com, orika@nvidia.com, radu.nicolau@intel.com, ruifeng.wang@arm.com, sameh.gobriel@intel.com, sivaprasad.tummala@amd.com, skori@marvell.com, stephen@networkplumber.org, suanmingm@nvidia.com, vattunuru@marvell.com, viacheslavo@nvidia.com, vladimir.medvedkin@intel.com, yipeng1.wang@intel.com, Andre Muezerie Subject: [PATCH v11 12/30] drivers/event: replace packed attributes Date: Fri, 10 Jan 2025 14:16:33 -0800 Message-Id: <1736547411-5895-13-git-send-email-andremue@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1736547411-5895-1-git-send-email-andremue@linux.microsoft.com> References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com> <1736547411-5895-1-git-send-email-andremue@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compiler warning if no existing packing has been pushed allowing easy identification of locations where the __rte_packed_begin is missing. Signed-off-by: Andre Muezerie Reviewed-by: Tyler Retzlaff --- drivers/event/octeontx/timvf_evdev.c | 4 ++-- drivers/event/octeontx/timvf_evdev.h | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/event/octeontx/timvf_evdev.c b/drivers/event/octeontx/timvf_evdev.c index 82f17144a6..b404b1db61 100644 --- a/drivers/event/octeontx/timvf_evdev.c +++ b/drivers/event/octeontx/timvf_evdev.c @@ -9,10 +9,10 @@ RTE_LOG_REGISTER_SUFFIX(otx_logtype_timvf, timer, NOTICE); static struct rte_eventdev *event_dev; -struct __rte_packed timvf_mbox_dev_info { +struct __rte_packed_begin timvf_mbox_dev_info { uint64_t ring_active[4]; uint64_t clk_freq; -}; +} __rte_packed_end; /* Response messages */ enum { diff --git a/drivers/event/octeontx/timvf_evdev.h b/drivers/event/octeontx/timvf_evdev.h index 44a4ee41c4..e9152424ab 100644 --- a/drivers/event/octeontx/timvf_evdev.h +++ b/drivers/event/octeontx/timvf_evdev.h @@ -123,7 +123,7 @@ enum timvf_clk_src { }; /* TIM_MEM_BUCKET */ -struct __rte_aligned(8) tim_mem_bucket { +struct __rte_aligned(8) __rte_packed_begin tim_mem_bucket { uint64_t first_chunk; union { RTE_ATOMIC(uint64_t) w1; @@ -139,19 +139,19 @@ struct __rte_aligned(8) tim_mem_bucket { }; uint64_t current_chunk; uint64_t pad; -} __rte_packed; +} __rte_packed_end; -struct tim_mem_entry { +struct __rte_packed_begin tim_mem_entry { uint64_t w0; uint64_t wqe; -} __rte_packed; +} __rte_packed_end; -struct timvf_ctrl_reg { +struct __rte_packed_begin timvf_ctrl_reg { uint64_t rctrl0; uint64_t rctrl1; uint64_t rctrl2; uint8_t use_pmu; -} __rte_packed; +} __rte_packed_end; struct timvf_ring; -- 2.47.0.vfs.0.3