From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7ED04A0C44; Mon, 12 Apr 2021 14:26:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D6AA14116A; Mon, 12 Apr 2021 14:26:22 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id AB1F1141163; Mon, 12 Apr 2021 14:26:21 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 0698B5C0140; Mon, 12 Apr 2021 08:26:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 12 Apr 2021 08:26:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= qINMpigEaRnIXjNYL9d1085LV0VgctdiD+UeGHOuzqA=; b=vPTPVOWY8W4GDJ/r FI4nTnQsR+aelk6Hp9Zbr9IkzH3+IJA4J0uBxzDxZ+FPb1rPbIdlFg3PsFC4jbio eT7/dFjv5l0ocwfC/TBQrVUPO3EHL9BI+7qTE2+0FKzKFYd8SVWgdD8xMucVmx5T sDSP30rjUKRguTPv/fudfkSIK9FMAyrDUdZuDikPdAyOs5ilqN9JMKiwxmg3SlJO UBGPtp9/FtIBpQLSh4b54242RQg5Q1IhmOuKbVRHDZwVKp/EO19ewLvALz/r9Qd5 kV8vEoNlsQIAILq+/hUJrHAMNyKA3qRabnktAnRAh6MFAXJ47zWlLMY/eDfy/ixd BujlGg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=qINMpigEaRnIXjNYL9d1085LV0VgctdiD+UeGHOuz qA=; b=EqJYF1sWaOW/cBfjBMkVAag7Q9xVy5bMszt0rclzkmL8RfxnVycps7Ban rLHYXf/aqg3NSwvLTEj02K0/SD6IJuWwUsNIhE8pwS/DUXhopkuDZ4ywZ0U2OFfI SSZGkWplIcRC+mxJSE2ePU4th4e343co66gzxejFwRwA6dxRn/bi99o6u5BoyLrj TR/R/CyTbnX2vutXHrJNthqvCFILT3X1xZbSGirprpYZFq9BpE/xyHKuDh1+p8+R xjsSyGsq7KAElXfFXulmjc1fheXhOzPoMMohiYGEF5h7Epi7+lGYI6+vhMz7obUb tT5FOle9YtlGKICfnBBTuj3N40fzA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekjedgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B87D3240054; Mon, 12 Apr 2021 08:26:19 -0400 (EDT) From: Thomas Monjalon To: Tal Shnaiderman , Raslan Darawsheh Cc: "dev@dpdk.org" , Matan Azrad , Asaf Penso , Wisam Monther , "stable@dpdk.org" Date: Mon, 12 Apr 2021 14:26:18 +0200 Message-ID: <1737490.Msu5DJBOj2@thomas> In-Reply-To: References: <20210411122136.2560-1-talshn@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] common/mlx5: fix missing __rte_internal tags in exported functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/04/2021 13:25, Raslan Darawsheh: > Removed __ from the commit title to fix wrong headline format issue. Removing __ makes it wrong: rte_internal does not exist. The idea of discouraging the use of underscore is to avoid naming bits and bytes in the title. Here it should be: "add missing internal tags to some functions" > > Several functions introduced in the addition of the Windows support to > > mlx5 were missing the __rte_internal tag although being exported.