DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] drivers/net: signed/unsigned mismatch
@ 2025-02-10 21:25 Andre Muezerie
  0 siblings, 0 replies; only message in thread
From: Andre Muezerie @ 2025-02-10 21:25 UTC (permalink / raw)
  To: Jochen Behrens; +Cc: dev, Andre Muezerie

This patch avoids warning C4018: '>=': signed/unsigned mismatch

The fix is to use U suffix to indicate the numbers are unsigned before
the comparisons are made.

Also renamed variables to make them compliant to DPDK standards and
avoid checkpatch warnings.

Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
 drivers/net/vmxnet3/vmxnet3_ethdev.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.h b/drivers/net/vmxnet3/vmxnet3_ethdev.h
index e9ded6663d..fd150d12c5 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.h
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.h
@@ -183,17 +183,17 @@ vmxnet3_read_addr(volatile void *addr)
 	VMXNET3_PCI_REG_WRITE(VMXNET3_PCI_BAR1_REG_ADDR((hw), (reg)), (value))
 
 static inline uint8_t
-vmxnet3_get_ring_idx(struct vmxnet3_hw *hw, uint32 rqID)
+vmxnet3_get_ring_idx(struct vmxnet3_hw *hw, uint32_t rq_id)
 {
-	return (rqID >= hw->num_rx_queues &&
-		rqID < 2 * hw->num_rx_queues) ? 1 : 0;
+	return (rq_id >= hw->num_rx_queues &&
+		rq_id < 2U * hw->num_rx_queues) ? 1 : 0;
 }
 
 static inline bool
-vmxnet3_rx_data_ring(struct vmxnet3_hw *hw, uint32 rqID)
+vmxnet3_rx_data_ring(struct vmxnet3_hw *hw, uint32_t rq_id)
 {
-	return (rqID >= 2 * hw->num_rx_queues &&
-		rqID < 3 * hw->num_rx_queues);
+	return (rq_id >= 2U * hw->num_rx_queues &&
+		rq_id < 3U * hw->num_rx_queues);
 }
 
 /*
-- 
2.47.2.vfs.0.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-02-10 21:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-10 21:25 [PATCH] drivers/net: signed/unsigned mismatch Andre Muezerie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).