From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C028461AD; Tue, 11 Feb 2025 23:02:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D96A440E42; Tue, 11 Feb 2025 23:02:44 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 545354027C for ; Tue, 11 Feb 2025 23:02:41 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id 7EB06210D0D8; Tue, 11 Feb 2025 14:02:40 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7EB06210D0D8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1739311360; bh=XrhVsA7T2O3T4yqgkATfJr+8rovNhlCNFPGElc0NZUU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A9BKgch2Sr8T/1a0Lyfr4cBGDd6Kk5G2EkPtUHq7M9tD5tL8RBAMBhZA611gVBEG7 meSiW6bqBZyX0uyI/DQGgFoA68LseAJkIpARQq0gQIjpo1gyCPFMkFtqpT8GkJtOoL p6EV1LEcxGKzKDbXzCuh1wtMzqnz6axVSRWs1FSA= From: Andre Muezerie To: Tyler Retzlaff Cc: dev@dpdk.org, Andre Muezerie Subject: [PATCH 02/10] test_alarm: avoid warning about different qualifiers Date: Tue, 11 Feb 2025 14:01:58 -0800 Message-Id: <1739311325-14425-3-git-send-email-andremue@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1739311325-14425-1-git-send-email-andremue@linux.microsoft.com> References: <1739311325-14425-1-git-send-email-andremue@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Compiling with MSVC results in the warning below: app/test/test_alarm.c(54): warning C4090: 'function': different '_Atomic' qualifiers The fix is to use a macro to explicitly drop the qualifier. Signed-off-by: Andre Muezerie --- app/test/test_alarm.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/test/test_alarm.c b/app/test/test_alarm.c index 9ed8c6f72c..6445f713fe 100644 --- a/app/test/test_alarm.c +++ b/app/test/test_alarm.c @@ -51,12 +51,12 @@ test_alarm(void) "Expected rte_eal_alarm_cancel to fail with null callback parameter"); /* check if can set a alarm for one second */ - TEST_ASSERT_SUCCESS(rte_eal_alarm_set(US_PER_SEC, test_alarm_callback, &triggered), - "Setting one second alarm failed"); + TEST_ASSERT_SUCCESS(rte_eal_alarm_set(US_PER_SEC, test_alarm_callback, + RTE_PTR_UNQUAL(&triggered)), "Setting one second alarm failed"); /* set a longer alarm that will be canceled. */ - TEST_ASSERT_SUCCESS(rte_eal_alarm_set(10 * US_PER_SEC, test_alarm_callback, &later), - "Setting ten second alarm failed"); + TEST_ASSERT_SUCCESS(rte_eal_alarm_set(10 * US_PER_SEC, test_alarm_callback, + RTE_PTR_UNQUAL(&later)), "Setting ten second alarm failed"); /* wait for alarm to happen */ while (rte_atomic_load_explicit(&triggered, rte_memory_order_acquire) == false) @@ -65,11 +65,11 @@ test_alarm(void) TEST_ASSERT(!rte_atomic_load_explicit(&later, rte_memory_order_acquire), "Only one alarm should have fired."); - ret = rte_eal_alarm_cancel(test_alarm_callback, &triggered); + ret = rte_eal_alarm_cancel(test_alarm_callback, RTE_PTR_UNQUAL(&triggered)); TEST_ASSERT(ret == 0 && rte_errno == ENOENT, "Canceling alarm after run ret %d: %s", ret, rte_strerror(rte_errno)); - ret = rte_eal_alarm_cancel(test_alarm_callback, &later); + ret = rte_eal_alarm_cancel(test_alarm_callback, RTE_PTR_UNQUAL(&later)); TEST_ASSERT(ret == 1, "Canceling ten second alarm failed %d: %s", ret, rte_strerror(rte_errno)); -- 2.47.2.vfs.0.1