From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B9F6A00BE; Thu, 28 May 2020 09:59:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 435531D9BF; Thu, 28 May 2020 09:59:18 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 6AE6E1D9B1 for ; Thu, 28 May 2020 09:59:17 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id DE11B5C01BB; Thu, 28 May 2020 03:59:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 28 May 2020 03:59:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= QEtnVNZ/MpNiQO2PtIQVPrRsHt+gy7R84Yse0oaM3Tw=; b=rD0qSRmCquZCIpNB LxB+V/f51MkJbrFpzsWtJ8Wr5HYU+K1D8/KKYkTnsTyhUNQE63aycLF+sqH9yZDu edNOE18SfH3paD/3qwDVVvKsBnlEebgbNOyjuNXcL281pqeoguUv8kGyiHAHCN1q wMdMPUK9lNo92roEU17yZGbvuoC5cOl8wEoeohu0272WGCoLCI83i3ykVycwJfMO LkMghhTLWCbnaLFz3p2WYKYNG1vporCkcfuaZ9VW/DYumBLbyhZRAAUkwIan+SG8 e1+403hZxQxGgg7CA6Hztw1iNBrXfUbHywifV3oQWCeLlEkuuqdI9PVn53J0MfaH ybGpkQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=QEtnVNZ/MpNiQO2PtIQVPrRsHt+gy7R84Yse0oaM3 Tw=; b=EuOK+T9OPjG12XIAUnAjvII/OrUsRAxCWLbaS2vgPQTEchzWZBTILeQMH dKS1kFyFqcorpRN4/8Xfbzsn//JlqjfONx/chlUMVgAB7L5TkEXNwm2KXaC+7gVZ vIcCWMlf71cOTO4suZI8KYpwMa1ZnFS3G/cFmd31SGKoJMF0+p2Wc8Vd01C+GoSA R8PpClLOjJSl0QBZUf05hKKxPIc5r1uQ7D09ijdJAR3cNLNoEgvRUx9m8Wj9jz6J c8ejbbK9MtBtiMw/YGm22kHsmDX2Oa5DRuacfjp6BrIu6otU4s/CUtCrnvdJnPGy 78ihIsdNLX3opGmnmT4jZyti1Q1pg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddvhedguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5E70A3280059; Thu, 28 May 2020 03:59:15 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, Dmitry Malloy , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman , Anatoly Burakov , Bruce Richardson Date: Thu, 28 May 2020 09:59:13 +0200 Message-ID: <1739619.a3TOMyy0yD@thomas> In-Reply-To: <20200525003720.6410-3-dmitry.kozliuk@gmail.com> References: <20200428235015.2820677-1-dmitry.kozliuk@gmail.com> <20200525003720.6410-1-dmitry.kozliuk@gmail.com> <20200525003720.6410-3-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 02/11] eal: introduce internal wrappers for file operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/05/2020 02:37, Dmitry Kozlyuk: > * eal_file_lock: lock or unlock an open file. > * eal_file_truncate: enforce a given size for an open file. [...] > Implementation for Linux and FreeBSD is placed in "unix" subdirectory, > which is intended for common code between the two. Files should be named > after the ones from which the code is factored in OS subdirectory. [...] > lib/librte_eal/unix/eal_unix.c | 51 ++++++++++++++++++++++ Why naming this file eal_unix? If it's truly global, it should be unix/eal.c If it's only about file operations, it could be unix/eal_file.c Please update MAINTAINERS when creating a new file. All files or directories must be listed in MAINTAINERS, even if there is no maintainer for them.