From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65CCA4626E; Thu, 20 Feb 2025 03:02:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2AB89402ED; Thu, 20 Feb 2025 03:01:56 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id E8C5540041 for ; Thu, 20 Feb 2025 03:01:48 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id 86332204E5B7; Wed, 19 Feb 2025 18:01:47 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 86332204E5B7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1740016907; bh=liCZLcoycSsNfp5uPsZ3tjg195UlGWkDRisIpPYcHZk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R6gYS4FZpYin+bfl4G21VbBVf2pgr7iZLmpeFlvaZC91VGVVw586CZFs7jjAcCBY4 mX419Kbi2aUPSUl6zLgCmFHxbSCldTjfFw4A+JxQQ+7GQ9/qbcnW0LsPnyp83k6yOA 8a3YjynnBjk9goH3noZuJT4ttm8Q/T0jLza8MdWM= From: Andre Muezerie To: andremue@linux.microsoft.com Cc: dev@dpdk.org, Chengwen Feng Subject: [PATCH v3 07/10] test-pmd: don't return value from void function Date: Wed, 19 Feb 2025 18:01:36 -0800 Message-Id: <1740016899-2817-8-git-send-email-andremue@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1740016899-2817-1-git-send-email-andremue@linux.microsoft.com> References: <1739311325-14425-1-git-send-email-andremue@linux.microsoft.com> <1740016899-2817-1-git-send-email-andremue@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Compiling with MSVC results in the warning below: app/test-pmd/cmdline_flow.c(13964): warning C4098: 'cmd_set_raw_parsed': 'void' function returning a value Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson --- app/test-pmd/cmdline_flow.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 24323d8891..15a18db2c7 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -13952,11 +13952,15 @@ cmd_set_raw_parsed(const struct buffer *in) int gtp_psc = -1; /* GTP PSC option index. */ const void *src_spec; - if (in->command == SET_SAMPLE_ACTIONS) - return cmd_set_raw_parsed_sample(in); + if (in->command == SET_SAMPLE_ACTIONS) { + cmd_set_raw_parsed_sample(in); + return; + } else if (in->command == SET_IPV6_EXT_PUSH || - in->command == SET_IPV6_EXT_REMOVE) - return cmd_set_ipv6_ext_parsed(in); + in->command == SET_IPV6_EXT_REMOVE) { + cmd_set_ipv6_ext_parsed(in); + return; + } RTE_ASSERT(in->command == SET_RAW_ENCAP || in->command == SET_RAW_DECAP); if (in->command == SET_RAW_ENCAP) { -- 2.48.1.vfs.0.0