DPDK patches and discussions
 help / color / mirror / Atom feed
From: Andre Muezerie <andremue@linux.microsoft.com>
To: andremue@linux.microsoft.com
Cc: dev@dpdk.org
Subject: [PATCH v3 5/6] net: update use of versioning macros
Date: Thu, 20 Feb 2025 12:31:47 -0800	[thread overview]
Message-ID: <1740083508-6703-6-git-send-email-andremue@linux.microsoft.com> (raw)
In-Reply-To: <1740083508-6703-1-git-send-email-andremue@linux.microsoft.com>

When compiling with MSVC the error below shows up due to function
versioning:

../lib/net/rte_net_crc.c(418): error C2061: syntax error:
    identifier '__attribute__'

MSVC allows alias function names to be exported, but the mechanism is
different than the one used by gcc. It was considered to enhance the logic
in the existing version.map files but that file is also passed to other
tools on Linux, making this challenging. A simpler approach is to have an
optional version.map file to be used only when Microsoft's linker is to be
used. This optional map file is only necessary for libraries that have
versioned code.

Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
 lib/net/rte_net_crc.c         |  2 ++
 lib/net/version_ms_linker.map | 23 +++++++++++++++++++++++
 2 files changed, 25 insertions(+)
 create mode 100644 lib/net/version_ms_linker.map

diff --git a/lib/net/rte_net_crc.c b/lib/net/rte_net_crc.c
index 2fb3eec231..5b41085a36 100644
--- a/lib/net/rte_net_crc.c
+++ b/lib/net/rte_net_crc.c
@@ -418,6 +418,7 @@ BIND_DEFAULT_SYMBOL(rte_net_crc_set_alg, _v26, 26);
 MAP_STATIC_SYMBOL(struct rte_net_crc *rte_net_crc_set_alg(
 	enum rte_net_crc_alg alg, enum rte_net_crc_type type),
 	rte_net_crc_set_alg_v26);
+MAP_STATIC_BASE_SYMBOL(rte_net_crc_set_alg, rte_net_crc_set_alg_v26)
 
 void rte_net_crc_free(struct rte_net_crc *crc)
 {
@@ -449,6 +450,7 @@ BIND_DEFAULT_SYMBOL(rte_net_crc_calc, _v26, 26);
 MAP_STATIC_SYMBOL(uint32_t rte_net_crc_calc(const struct rte_net_crc *ctx,
 	const void *data, const uint32_t data_len),
 	rte_net_crc_calc_v26);
+MAP_STATIC_BASE_SYMBOL(rte_net_crc_calc, rte_net_crc_calc_v26)
 
 /* Call initialisation helpers for all crc algorithm handlers */
 RTE_INIT(rte_net_crc_init)
diff --git a/lib/net/version_ms_linker.map b/lib/net/version_ms_linker.map
new file mode 100644
index 0000000000..9503c669d1
--- /dev/null
+++ b/lib/net/version_ms_linker.map
@@ -0,0 +1,23 @@
+DPDK_25 {
+	global:
+
+	rte_eth_random_addr;
+	rte_ether_format_addr;
+	rte_ether_unformat_addr;
+	rte_net_crc_calc=rte_net_crc_calc_v26;
+	rte_net_crc_free;
+	rte_net_crc_set_alg=rte_net_crc_set_alg_v26;
+	rte_net_get_ptype;
+	rte_net_make_rarp_packet;
+	rte_net_skip_ip6_ext;
+
+	local: *;
+};
+
+DPDK_26 {
+	global:
+
+	rte_net_crc_calc=rte_net_crc_calc_v26;
+	rte_net_crc_set_alg=rte_net_crc_set_alg_v26;
+
+} DPDK_25;
-- 
2.48.1.vfs.0.0


  parent reply	other threads:[~2025-02-20 20:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-10 21:51 [PATCH] mbuf: enable to be compiled with MSVC Andre Muezerie
2025-02-10 22:34 ` Stephen Hemminger
2025-02-11  2:19   ` Andre Muezerie
2025-02-12 14:23     ` Thomas Monjalon
2025-02-12 16:24       ` Thomas Monjalon
2025-02-19  1:39 ` [PATCH v2 0/5] " Andre Muezerie
2025-02-19  1:39   ` [PATCH v2 1/5] doc: update guide on versioning macros Andre Muezerie
2025-02-19  1:39   ` [PATCH v2 2/5] buildtools: update map_to_win.py to use optional map file Andre Muezerie
2025-02-19  1:39   ` [PATCH v2 3/5] eal: update versioning macros Andre Muezerie
2025-02-19  1:39   ` [PATCH v2 4/5] net: update use of " Andre Muezerie
2025-02-19  1:39   ` [PATCH v2 5/5] mbuf: enable to be compiled with MSVC Andre Muezerie
2025-02-20 20:31 ` [PATCH v3 0/6] " Andre Muezerie
2025-02-20 20:31   ` [PATCH v3 1/6] doc: update guide on versioning macros Andre Muezerie
2025-02-20 20:31   ` [PATCH v3 2/6] buildtools: update map_to_win.py to use optional map file Andre Muezerie
2025-02-20 20:31   ` [PATCH v3 3/6] eal: update versioning macros Andre Muezerie
2025-02-20 20:31   ` [PATCH v3 4/6] devtools: check ms linker map files Andre Muezerie
2025-02-20 20:31   ` Andre Muezerie [this message]
2025-02-20 20:31   ` [PATCH v3 6/6] mbuf: enable to be compiled with MSVC Andre Muezerie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1740083508-6703-6-git-send-email-andremue@linux.microsoft.com \
    --to=andremue@linux.microsoft.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).