From: Andre Muezerie <andremue@linux.microsoft.com>
To: "Bruce Richardson" <bruce.richardson@intel.com>,
"Konstantin Ananyev" <konstantin.v.ananyev@yandex.ru>,
"Sivaprasad Tummala" <sivaprasad.tummala@amd.com>,
"Morten Brørup" <mb@smartsharesystems.com>
Cc: dev@dpdk.org, Andre Muezerie <andremue@linux.microsoft.com>,
stable@dpdk.org
Subject: [PATCH] config/x86: increase lcores for AMD EPYC in 'native' scenario
Date: Fri, 28 Feb 2025 12:35:46 -0800 [thread overview]
Message-ID: <1740774946-20418-1-git-send-email-andremue@linux.microsoft.com> (raw)
File config/meson.build has logic to move cpu_instruction_set from 'auto'
to 'native' or 'generic'.
When calling get_option('cpu_instruction_set') again from
config/x86/meson.build we get 'auto' again, instead of expected 'native'.
The fix is to not call get_option('cpu_instruction_set') again, just rely
on the work done by config/meson.build and trust that cpu_instruction_set
already has the correct value. Note that getting/processing
cpu_instruction_set is not x86-specific, so should be handled by
config/meson.build.
Fixes: fd8b058b322e ("config/x86: increase lcores for AMD EPYC cross build")
Cc: stable@dpdk.org
Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
config/x86/meson.build | 1 -
1 file changed, 1 deletion(-)
diff --git a/config/x86/meson.build b/config/x86/meson.build
index 47a5b0c04a..a6d917c78c 100644
--- a/config/x86/meson.build
+++ b/config/x86/meson.build
@@ -104,7 +104,6 @@ epyc_zen_cores = {
'__znver1__':128
}
-cpu_instruction_set = get_option('cpu_instruction_set')
if cpu_instruction_set == 'native'
foreach m:epyc_zen_cores.keys()
if cc.get_define(m, args: machine_args) != ''
--
2.48.1.vfs.0.0
reply other threads:[~2025-02-28 20:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1740774946-20418-1-git-send-email-andremue@linux.microsoft.com \
--to=andremue@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=mb@smartsharesystems.com \
--cc=sivaprasad.tummala@amd.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).