From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Huawei Xie <huawei.xie@intel.com>
Cc: dev@dpdk.org, vincent.mc.li@gmail.com, yuanhan.liu@intel.com
Subject: Re: [dpdk-dev] [PATCH] virtio: check if devargs is NULL before checking its value
Date: Wed, 25 May 2016 12:47:30 +0200 [thread overview]
Message-ID: <1740935.53DGeJ2mHm@xps13> (raw)
In-Reply-To: <1464100542-48126-1-git-send-email-huawei.xie@intel.com>
> - dev->devargs->type != RTE_DEVTYPE_WHITELISTED_PCI) {
> + (!dev->devargs ||
> + dev->devargs->type != RTE_DEVTYPE_WHITELISTED_PCI)) {
Should the title be something like "fix crash ..."?
I would also add
Reported-by: Vincent Li <vincent.mc.li@gmail.com>
next prev parent reply other threads:[~2016-05-25 10:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 14:35 Huawei Xie
2016-05-25 10:47 ` Thomas Monjalon [this message]
2016-05-27 2:09 ` Yuanhan Liu
2016-06-01 5:50 ` Xie, Huawei
2016-06-13 14:53 ` [dpdk-dev] [PATCH v2] virtio: fix crash loading virtio driver when devargs isn't specified Huawei Xie
2016-06-14 13:19 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1740935.53DGeJ2mHm@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=vincent.mc.li@gmail.com \
--cc=yuanhan.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).