From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id A78D12BA7 for ; Wed, 25 May 2016 12:47:32 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id z87so57221043wmh.0 for ; Wed, 25 May 2016 03:47:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=TlUL6NH1xtV5FDezK2zoGuqFLL25m9eKVIisWUmO7Aw=; b=MKT1hbqWA0mgNetRTFJwTf7PSlGZ0O8TGC7a1QfzKPNHQd0ehOhdYnUUTCLA7blh25 WIOoTRAL22snHs6XTOc9O0QQABtpc5JII8nidxHcmqUirFylFE2mM1btbkr2TxUIZeX1 +wxmAMDeLujvQrIwDh1g9IwSDrlRdA0SiQPekc/oaJMEcgg/vMNdcJvjld6fZ6Bg126Z bxz9zAFsGWjC62xsYuE8AiWcem7CDEmRqZMGLYLTIkKi6T7jkqxba4V3Y4PqDmXb/COg 5YEVnzUxIj1BxdsT8yUjcty0AKoWeQyyP4zwP3XFUy/EK2cRuCua2HfcL9SbFPmcGwNn v3oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=TlUL6NH1xtV5FDezK2zoGuqFLL25m9eKVIisWUmO7Aw=; b=cIM7gRR14/5r928+RWQQOLBtD0YjM/VSmk10W6rlIsTlMRuA2ZAU/HUGm3EuTUjyID iYBAidGtBcJse7g3j9oAb07MP8OPqk0T6xaZyu/WRo7CgRLrFcbi2fIGEgEAAjm2qBme KZ3lYfpgSi0VLyu+Thw8R7kOO/cmm2B5AA6KTvc9uXPpjQvfMDkjuhYyTRAVGDatgRU8 3rH5eBTOMkgeI25JZOXQ0qUlaGMzjoz6Th4T3iuRTo1CC5SqBtxG22acv8WG/S/Vfh5D iHLH3RTOSeNU9IC7ODelagMw3cjMb9qKySDqayxDu/WRIyQobnSVIPe4XbCKirW8nJOM Eesg== X-Gm-Message-State: ALyK8tKlLjWu07h5czvx9n5h5EqJi044ws7fcFpHfaLrxE2GxydHsfbUqBcoP5MEQHn7a55e X-Received: by 10.194.104.228 with SMTP id gh4mr3033743wjb.134.1464173252478; Wed, 25 May 2016 03:47:32 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id jp2sm8081383wjc.16.2016.05.25.03.47.31 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 25 May 2016 03:47:31 -0700 (PDT) From: Thomas Monjalon To: Huawei Xie Cc: dev@dpdk.org, vincent.mc.li@gmail.com, yuanhan.liu@intel.com Date: Wed, 25 May 2016 12:47:30 +0200 Message-ID: <1740935.53DGeJ2mHm@xps13> User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1464100542-48126-1-git-send-email-huawei.xie@intel.com> References: <1464100542-48126-1-git-send-email-huawei.xie@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] virtio: check if devargs is NULL before checking its value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2016 10:47:32 -0000 > - dev->devargs->type != RTE_DEVTYPE_WHITELISTED_PCI) { > + (!dev->devargs || > + dev->devargs->type != RTE_DEVTYPE_WHITELISTED_PCI)) { Should the title be something like "fix crash ..."? I would also add Reported-by: Vincent Li