From: Andre Muezerie <andremue@linux.microsoft.com>
To: andremue@linux.microsoft.com
Cc: bruce.richardson@intel.com, dev@dpdk.org,
sameh.gobriel@intel.com, vladimir.medvedkin@intel.com,
yipeng1.wang@intel.com
Subject: [PATCH v2 2/3] hash_multiwriter_autotest: fix printf parameters
Date: Tue, 11 Mar 2025 08:33:14 -0700 [thread overview]
Message-ID: <1741707195-26880-2-git-send-email-andremue@linux.microsoft.com> (raw)
In-Reply-To: <1741707195-26880-1-git-send-email-andremue@linux.microsoft.com>
Compiling with MSVC logs the warnings below, which result in
build error:
../app/test/test_hash_multiwriter.c(71): warning C4476: 'printf' :
unknown type field character ''' in format specifier
../app/test/test_hash_multiwriter.c(73): warning C4474: 'printf' :
too many arguments passed for format string
../app/test/test_hash_multiwriter.c(73): note: placeholders and their
parameters expect 2 variadic arguments, but 4 were provided
Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
app/test/test_hash_multiwriter.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/app/test/test_hash_multiwriter.c b/app/test/test_hash_multiwriter.c
index 33d3147bd8..5c1dd4c195 100644
--- a/app/test/test_hash_multiwriter.c
+++ b/app/test/test_hash_multiwriter.c
@@ -32,6 +32,8 @@
#define RTE_APP_TEST_HASH_MULTIWRITER_FAILED 0
+#define OFFSET_STR_LEN 16
+
struct {
uint32_t *keys;
uint32_t *found;
@@ -51,11 +53,14 @@ static int use_htm;
static int
test_hash_multiwriter_worker(void *arg)
{
+ char offset_start[OFFSET_STR_LEN];
+ char offset_end[OFFSET_STR_LEN];
uint64_t i, offset;
uint16_t pos_core;
uint32_t lcore_id = rte_lcore_id();
uint64_t begin, cycles;
uint16_t *enabled_core_ids = (uint16_t *)arg;
+ const bool use_iec = true;
for (pos_core = 0; pos_core < rte_lcore_count(); pos_core++) {
if (enabled_core_ids[pos_core] == lcore_id)
@@ -68,10 +73,12 @@ test_hash_multiwriter_worker(void *arg)
*/
offset = pos_core * tbl_multiwriter_test_params.nb_tsx_insertion;
- printf("Core #%d inserting %d: %'"PRId64" - %'"PRId64"\n",
+ rte_size_to_str(offset_start, sizeof(offset_start), offset, use_iec);
+ rte_size_to_str(offset_end, sizeof(offset_end),
+ offset + tbl_multiwriter_test_params.nb_tsx_insertion - 1, use_iec);
+ printf("Core #%u inserting %u: %s - %s\n",
lcore_id, tbl_multiwriter_test_params.nb_tsx_insertion,
- offset,
- offset + tbl_multiwriter_test_params.nb_tsx_insertion - 1);
+ offset_start, offset_end);
begin = rte_rdtsc_precise();
--
2.48.1.vfs.0.1
next prev parent reply other threads:[~2025-03-11 15:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 20:03 [PATCH] hash_readwrite_autotest: " Andre Muezerie
2025-03-07 9:01 ` Bruce Richardson
2025-03-07 22:34 ` Andre Muezerie
2025-03-10 10:51 ` Bruce Richardson
2025-03-10 15:36 ` Stephen Hemminger
2025-03-11 14:39 ` Andre Muezerie
2025-03-11 15:01 ` Morten Brørup
2025-03-11 15:33 ` [PATCH v2 1/3] eal: add function rte_size_to_str Andre Muezerie
2025-03-11 15:33 ` Andre Muezerie [this message]
2025-03-11 15:33 ` [PATCH v2 3/3] hash_readwrite_autotest: fix printf parameters Andre Muezerie
2025-03-11 15:49 ` [PATCH v2 1/3] eal: add function rte_size_to_str Stephen Hemminger
2025-03-11 15:51 ` Bruce Richardson
2025-03-11 16:21 ` Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1741707195-26880-2-git-send-email-andremue@linux.microsoft.com \
--to=andremue@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=sameh.gobriel@intel.com \
--cc=vladimir.medvedkin@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).