From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 477F56CC5 for ; Thu, 17 May 2018 15:12:51 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BB90A21511; Thu, 17 May 2018 09:12:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 17 May 2018 09:12:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=6hgSuWe19SEBjw68INdUsr1AUW 6EWkG+P3rBQgK9nTI=; b=ieZbTrfjLxuedA5KIBBGi01+AJtFYnIet/m3KPp39O fYfCBN3+TaMazTTQsjG9FZi5Yz6xoah5+ko8ZxbJi49T1BkjPDtLC8w4vnEAHg6O mqGM9s6ykzB/qYZJBLK6HvEP5h3A++fMZk8dnGzQ3Io8awD7YcnCz5aXCFeq9IPf 4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=6hgSuW e19SEBjw68INdUsr1AUW6EWkG+P3rBQgK9nTI=; b=NYMrhWOAOk4l5EGGLzAn6G 5sQlaAa+8j87/OTAus3o6HiLk3jERhvy8tesc++uXYTIfNHqWIMUTteQdnE/ZDcL 7h259t9KS3kQ8yxzCOBca+V7KKs0QrGQ4aerzZeyw5cT4pGHpm5B8cfCy2cWM1vn qeUd/bKjl/83U0Yg6YS7VxE0nj0Z/D/j2MX/mEBJcdaG5WLaN6FujViXeplX7nIb dJjNdR0avG2UXlMVjDaPtWr0r2nArfU6qVUa0fsMa9LhEZiTMATicg9KdEz51SO1 rOAnbWHVHp8Yrae7XMb5PiNKltNyHqoz53e4lydaQ8iw0cvw0abNq2g8O0F8QT1w == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D7CE9E4660; Thu, 17 May 2018 09:12:49 -0400 (EDT) From: Thomas Monjalon To: Luca Boccassi Cc: Kevin Traynor , dev@dpdk.org, yliu@fridaylinux.org Date: Thu, 17 May 2018 15:12:48 +0200 Message-ID: <1744032.J4TBba0YLV@xps> In-Reply-To: <1526490189.23337.129.camel@debian.org> References: <20180516143134.24838-1-luca.boccassi@gmail.com> <7a747fd8-174c-9c10-b9ab-ed0d74555844@redhat.com> <1526490189.23337.129.camel@debian.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: advise to specify LTS branch when backporting patches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 13:12:51 -0000 16/05/2018 19:03, Luca Boccassi: > On Wed, 2018-05-16 at 16:19 +0100, Kevin Traynor wrote: > > On 05/16/2018 03:31 PM, luca.boccassi@gmail.com wrote: > > > From: Luca Boccassi > > > > > > We have many stable branches being maintaned at the same time, and > > > > typo > > > > > sometimes it's not clear which branch a patch is being backported > > > for. > > > Note in the guidelines that it should be specified via the cover > > > letter, > > > annotation or using --subject-prefix. > > > Also note to send only to stable@dpdk.org, not dev@dpdk.org. > > > > > > Signed-off-by: Luca Boccassi > > > --- > > > doc/guides/contributing/patches.rst | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/doc/guides/contributing/patches.rst > > > b/doc/guides/contributing/patches.rst > > > index 2287835f9..1dc623a23 100644 > > > --- a/doc/guides/contributing/patches.rst > > > +++ b/doc/guides/contributing/patches.rst > > > @@ -450,6 +450,14 @@ Experienced committers may send patches > > > directly with ``git send-email`` without > > > The options ``--annotate`` and ``confirm = always`` are > > > recommended for checking patches before sending. > > > > > > > > > +Backporting patches for Stable Releases > > > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > + > > > +Sometimes a maintainer or contributor wishes, or can be asked, to > > > send a patch for a stable release rather than mainline. In this > > > case the patch(es) should be sent to ``stable@dpdk.org``, not to `` > > > dev@dpdk.org``. > > > + > > > +Given that there are multiple stable releases being maintained at > > > the same time, please specify exactly which branch the patch is for > > > in the cover letter, in the annotation or using ``git send-email -- > > > subject-prefix='16.11' ...`` > > > + > > > > s/branch/branch(es)/ > > > > How about [16.11] instead of '16.11' ? > > Using --subject-prefix git will already use "[PATCH 16.11] I think it should be --subject-prefix='PATCH 16.11' Please wrap the lines after some punctuation signs to avoid really long lines in the rst file.