From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com
 [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id CF50858C4
 for <dev@dpdk.org>; Tue,  7 Oct 2014 18:24:15 +0200 (CEST)
Received: by mail-wi0-f174.google.com with SMTP id cc10so8488533wib.1
 for <dev@dpdk.org>; Tue, 07 Oct 2014 09:31:29 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=dEFeyUhG22bYKT8Ca1RRapg3C7MolWDBhQ5FPuL87rw=;
 b=Vt1UsfOvWalFhrFMP906Ps4tPWiyK128G4WeSgwKIAkNUXXwhPiI38mkT75p1MOxNi
 Hs8GTI8qOrvdeJAXI+VRM7/5skooehYzRgTx/DIOausV8Jz9T6oTYBec0FBFUlmUzk73
 uGi59geDMPwuP8+8Oe5zfeoj5Pqqr9ySpBF1QuR8gEPZfCWHEyqeaOJ5Y2j8HB9q8+/g
 Gf8I01DHlWsGeQfNq6naY3Hgvg1oDKzPCLOaB17RsQmjF/2OEudDq4k+tbBN4guQkEtc
 tGxViy7DmveesjnhT1S0rtE144X6Ta80ry+BcqH0qO7mYl7FZ4glEDbAcv20wJXKZQsK
 1l1w==
X-Gm-Message-State: ALoCoQlwqEnhm5D7k30gshEPOpRiFMEMCAm1RNshxAdcRSkqu81K74rXOQf5f3Ug7TvnrK8NdGNW
X-Received: by 10.194.179.73 with SMTP id de9mr6199486wjc.87.1412699489167;
 Tue, 07 Oct 2014 09:31:29 -0700 (PDT)
Received: from xps13.localnet (108.26.90.92.rev.sfr.net. [92.90.26.108])
 by mx.google.com with ESMTPSA id j8sm6071298wib.10.2014.10.07.09.31.27
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 07 Oct 2014 09:31:28 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Helin Zhang <helin.zhang@intel.com>
Date: Tue, 07 Oct 2014 18:31:08 +0200
Message-ID: <17441317.gxiFn6uigt@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )
In-Reply-To: <1410247299-4365-1-git-send-email-helin.zhang@intel.com>
References: <1410247299-4365-1-git-send-email-helin.zhang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 00/15] i40e base driver udpate
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Oct 2014 16:24:16 -0000

> Here is the update of i40e base driver. Also it involves a few
> relevant necessary code changes in i40e PMD.
> 
> Helin Zhang (15):
>   i40e: make the indentation more consistent in share code
>   i40e: support nvmupdate by default
>   i40e: remove useless code which was written for Solaris
>   i40e: remove test code for 'ethtool'
>   i40e: force a shifted '1' to be 'unsigned'
>   i40e: remove useless code for pre-boot support
>   i40e: Get rid of sparse warnings, and remove unreachable code
>   i40e: remove code which is for software validation only
>   i40e: remove code for TPH (TLP Processing Hints)
>   i40e: support of 10G base T
>   i40e: expose debug_write_register request
>   i40e: workaround of get_firmware_version, and enhancements
>   i40e: Use get_link_status to report FC settings
>   i40e: fix and enhancement in arq_event_info struct
>   i40e: support redefined struct of 'i40e_arq_event_info'

Applied

Nice work, only 2 comments:
- title should begin with i40e/base
- last 2 patches are dependent and cannot be splitted without
  breaking compilation

Thanks
-- 
Thomas