DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] mk: fix compile error and ABI versioning for combined shared library
Date: Thu, 03 Dec 2015 02:36:53 +0100	[thread overview]
Message-ID: <1744460.N1LazHY3fl@xps13> (raw)
In-Reply-To: <1449105754-17136-1-git-send-email-ferruh.yigit@intel.com>

Hi Ferruh,

Thanks for working on it.

2015-12-03 01:22, Ferruh Yigit:
> +ifeq ($(COMBINED_BUILD),1)
>  include $(RTE_SDK)/mk/rte.sharelib.mk
> +endif
[...]
>  	@if [ $@ = drivers -a $(CONFIG_RTE_BUILD_COMBINE_LIBS) = y ]; then \
> -		$(MAKE) -f $(RTE_SDK)/lib/Makefile sharelib; \
> +		COMBINED_BUILD=1 $(MAKE) -f $(RTE_SDK)/lib/Makefile sharelib; \

What is it fixing?
The badly named sharelib is for combined build only.

[...]
> +FILES=$(find $RTE_SDK -name "*.map" | grep -v build)

The build dir is not always "build/"

  reply	other threads:[~2015-12-03  1:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-03  1:22 Ferruh Yigit
2015-12-03  1:36 ` Thomas Monjalon [this message]
2015-12-03  1:59   ` Ferruh Yigit
2015-12-03  2:15     ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2015-12-03  2:22       ` Thomas Monjalon
2015-12-03 11:24         ` Ferruh Yigit
2015-12-03  8:18 ` [dpdk-dev] [PATCH v2] " Christian Ehrhardt
2015-12-03 11:18   ` Ferruh Yigit
2015-12-03 14:01     ` Ferruh Yigit
2015-12-03 12:49 ` Panu Matilainen
2015-12-03 13:51   ` [dpdk-dev] [PATCH v4] " Ferruh Yigit
2015-12-06 14:37     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1744460.N1LazHY3fl@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).