From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id 2938C37A6
 for <dev@dpdk.org>; Thu,  3 Dec 2015 02:38:03 +0100 (CET)
Received: by wmww144 with SMTP id w144so2574651wmw.0
 for <dev@dpdk.org>; Wed, 02 Dec 2015 17:38:03 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:organization:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding
 :content-type; bh=xCvGIPmBgsXgrVd+t0EtOeKm/fr45uDi2zr+RO/KxnE=;
 b=E3rOZVLATeNdycVZjGhxLe1an/c9joXd9SZmJIMoisJAdL8VtZeWMwsxSlyBLKitWB
 Y0jcmJVd/HclXjBnCGUvMLZGSOtJ3U5ii1mZMTmwdMDAuiCRJ7AV7pWs57sF0KbecZxu
 3bD7rGzDDomlOqaOHcl+zwX8GG1iN/wmscmp6kn3g5xnxTpLLETioxXpQcHp1EWbWYD/
 POlTL2h93uWNaaVWoYIAxPDKXyI5rwuipcQ4kl6qpYNeLYI9S0dlfmU8iDMGAy90bQi4
 0p6SjGBdErw+yB2WBgWwHMpmv3Y4zhjLjO05klGZcxRpN2/UWnbLC/W3dA16j6SpeSbX
 V8ow==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=xCvGIPmBgsXgrVd+t0EtOeKm/fr45uDi2zr+RO/KxnE=;
 b=H07OfZvHTqlxh4MujrPsDGPhhvPpvVcRfxgAgrHgINwRhLojL8vWuOekzbu2kBMZwx
 iljogs/K4bnEsBu2SAJOnwpgZVCfw4CnkK5vzyKdyNv4aDTiajPXH2mwoA5opK7IrdEc
 Urzg+yQhDF81UfolexVnSDpeF6wnM0hTR1axss9lP4qzQixUCnUNn1uqD8G1e3Vx9pWV
 ROJzTIAzWi/IxlVSKQYL5oV6aQO30wPN8SdiikvUCl/+eFxbJmrJ2omEFnRbbr9zJ//g
 Y6ZiUbZZqQPtHaiwSjoOxTa4+/CvWSOFCMDcmRrLFxV/xybRWpEJ+I0ITG+Fcc8zjY76
 Owwg==
X-Gm-Message-State: ALoCoQndbEwhnXudXZ5NQeO2K3obfTpRcjm2/EkPR9teKxImTMAUtBELt+bjuVEl5W77edBegzc3
X-Received: by 10.194.58.142 with SMTP id r14mr9331638wjq.37.1449106682978;
 Wed, 02 Dec 2015 17:38:02 -0800 (PST)
Received: from xps13.localnet ([93.158.46.55])
 by smtp.gmail.com with ESMTPSA id q74sm362659wmd.0.2015.12.02.17.38.01
 (version=TLSv1/SSLv3 cipher=OTHER);
 Wed, 02 Dec 2015 17:38:02 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Date: Thu, 03 Dec 2015 02:36:53 +0100
Message-ID: <1744460.N1LazHY3fl@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1449105754-17136-1-git-send-email-ferruh.yigit@intel.com>
References: <1449105754-17136-1-git-send-email-ferruh.yigit@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] mk: fix compile error and ABI versioning
	for combined shared library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Dec 2015 01:38:03 -0000

Hi Ferruh,

Thanks for working on it.

2015-12-03 01:22, Ferruh Yigit:
> +ifeq ($(COMBINED_BUILD),1)
>  include $(RTE_SDK)/mk/rte.sharelib.mk
> +endif
[...]
>  	@if [ $@ = drivers -a $(CONFIG_RTE_BUILD_COMBINE_LIBS) = y ]; then \
> -		$(MAKE) -f $(RTE_SDK)/lib/Makefile sharelib; \
> +		COMBINED_BUILD=1 $(MAKE) -f $(RTE_SDK)/lib/Makefile sharelib; \

What is it fixing?
The badly named sharelib is for combined build only.

[...]
> +FILES=$(find $RTE_SDK -name "*.map" | grep -v build)

The build dir is not always "build/"