From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id C2427A49C for ; Sat, 20 Jan 2018 15:36:46 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3EF6720B58; Sat, 20 Jan 2018 09:36:46 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Sat, 20 Jan 2018 09:36:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=C0CM8wPeV2K+MONhVMWx5xyaQq JqBg9vBh28VfQOBI4=; b=lKF/+3w/U26LwebNLqWqfkeBhsCEV9P2FrBV99W/DU IGcwAPNy5STZ+1YDjiZ3EjqbJGh2T/G3C8n3fsPNpeWUekrcUwpmy6sh2A0DCd/h p9qWdo+GCuGW6IKkpvQyQp0nXYrbMq+BEsNLCTzSQUiyHxvSGsNCFW5Bk5A/2ljf s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=C0CM8w PeV2K+MONhVMWx5xyaQqJqBg9vBh28VfQOBI4=; b=Ov7sF1d5Xfn5iGFz6YhDhz SGKNTbZDgPO4NUuuXSZRTbYm1nBTuZN570i6TqlP2iED3+NkhlB2Eg8Zokx3qpVe CQTr3IVaSmik8lm4XqCH7ycHyZzhDeb8uJG9SHF+0zRnP/7zkjz24D1+vzCs8s3S YiZuB15PrHPQf9y76J3vwT06EZCLdhSHpu1h1EmJV1DtXf9qrg7FP7Q7QFYbN74y 2/3t8yYisrynofxIPkmdtzvy+t1ejsjKgZ5rvUXl7A/o7W0aFo3c612uh0ijTYaO fgO98JBiOICMXFFOFAR9P8Ib67Gi672giTbl1IIhxnq8tj6v4KilLprfbnm8QR1g == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DE7EF24608; Sat, 20 Jan 2018 09:36:45 -0500 (EST) From: Thomas Monjalon To: Elza Mathew Cc: dev@dpdk.org, Bruce Richardson , pablo.de.lara.guarch@intel.com Date: Sat, 20 Jan 2018 15:36:10 +0100 Message-ID: <1746855.zJqQpDPaSL@xps> In-Reply-To: <20171211125210.GA15784@bricha3-MOBL3.ger.corp.intel.com> References: <1509991442-26391-1-git-send-email-elza.mathew@intel.com> <20171211125210.GA15784@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/3] hash: run-time function selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jan 2018 14:36:47 -0000 11/12/2017 13:52, Bruce Richardson: > On Mon, Nov 06, 2017 at 10:04:02AM -0800, Elza Mathew wrote: > > Compile-time function selection can potentially lead to > > lower performance on generic builds done by distros. > > Replaced compile time flag checks with run-time function > > selection. > > > > Signed-off-by: Elza Mathew > > --- > > lib/librte_hash/rte_cuckoo_hash.c | 10 +++++++++- > > lib/librte_hash/rte_cuckoo_hash.h | 6 ------ > > 2 files changed, 9 insertions(+), 7 deletions(-) > > > > Looks good to me. > > Acked-by: Bruce Richardson Applied, thanks