From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id CB05E7CD6 for ; Mon, 29 May 2017 13:21:03 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id b84so52019533wmh.0 for ; Mon, 29 May 2017 04:21:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weka.io; s=google; h=from:to:cc:subject:date:message-id:organization:in-reply-to :references:mime-version:content-transfer-encoding; bh=o/t2Chw0q9xZ3a556cWNdHprA0u8rtM1BPmVL4i9WBM=; b=JtxgJrC5okycDa74x3MhStnmAyikqFZ5o1+fVUbIhm2FqTT5sjQbJ108IGutTp5/n6 lyg6Huf014uH9rW6K8TrfjQn/fWKD0kjSgzhNpMxIjXAQ2jsHlhAD8RTd8VEdvLkPWRG BGpMHHjCcLU5B4pGMDc218pvsaZks2UaAekFc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :in-reply-to:references:mime-version:content-transfer-encoding; bh=o/t2Chw0q9xZ3a556cWNdHprA0u8rtM1BPmVL4i9WBM=; b=nXLLc5Ws5XyC85r3YKHmGlxVPmdPhypJCTOozIoFGpTKowfdUlE+1O1yj9eoNzQNa6 5M+bbPN0SKEUZtGmgdv22lRGvVqEazh4eJl9mbThPTyUEl1gn8dC1E3K+OyfSY1ixAb/ vyeUNU99qYYu7cGb14DKbr2mqRtXH6M4aYozj9TvZ0Do5qcmO6zmvVKDd0LpmK1stuDm hJvBTvrKtnlDaTjd5Tm+PaZ+xviukx92U+QTRTUNy0wisT4dljCCHwRIvf3FpxXrUo7/ otNIbMDLvo6FG1OVNM99y54WV3xOyHjWRrpV+1GF0qKaceLwYybUjN/dx4C+4lzHLDlw OzRQ== X-Gm-Message-State: AODbwcAbpimQ/PybgfWXZnjUDH7qGATp2fbAgqi9NgcbcJWUI8zsZFIv 56X28Rztcz3yg0uV X-Received: by 10.28.71.201 with SMTP id m70mr20076624wmi.89.1496056863497; Mon, 29 May 2017 04:21:03 -0700 (PDT) Received: from polaris.localnet (bzq-82-81-85-138.red.bezeqint.net. [82.81.85.138]) by smtp.gmail.com with ESMTPSA id u19sm356531wrb.27.2017.05.29.04.21.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 May 2017 04:21:02 -0700 (PDT) From: Gregory Etelson To: Shijith Thotton Cc: Stephen Hemminger , dev@dpdk.org, Ferruh Yigit , Qi Zhang , Wenzhuo Lu Date: Mon, 29 May 2017 14:21:01 +0300 Message-ID: <1748341.rbpcFmWp0q@polaris> Organization: Weka.IO In-Reply-To: <20170529110141.GB28265@localhost.localdomain> References: <106841857.Z7q1jSDIte@polaris> <2463262.6ozr8bnjWv@polaris> <20170529110141.GB28265@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] i40e igb_uio: reset pci on process exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2017 11:21:04 -0000 PMD already resets PCI during initialization. In my patch, exiting process forced to release it's resources On Monday, 29 May 2017 14:01:48 IDT Shijith Thotton wrote: > On Mon, May 29, 2017 at 01:01:06PM +0300, Gregory Etelson wrote: > > I still have to support Red Hat 6.x. These system do not have VFIO > > > > IGB_UIO is the only option there. > > > > Also, there was a discussion that claimed IGB_UIO has better performance > > than VFIO. > > > > http://dpdk.org/ml/archives/dev/2014-August/004609.html > > > > Regards, > > Gregory > > > > [..] > >> static int > >> igbuio_pci_open(struct uio_info *info, struct inode *inode) > >> { > >> struct rte_uio_pci_dev *udev = info->priv; > >> struct pci_dev *dev = udev->pdev; > >> > >> return pci_reset_function(dev); > >> } > >> > >> and.. > >> udev->info.open = igbuio_pci_open; > >> > > I was suggesting to make reset part of open. It should work on your setup. > > - udev->info.release = igbuio_pci_release; > + udev->info.open = igbuio_pci_open; > > Shijith >