From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DD2246814; Wed, 28 May 2025 15:22:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0C5940DFB; Wed, 28 May 2025 15:22:58 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id B734740669 for ; Wed, 28 May 2025 15:22:57 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1213) id C9EAD206788C; Wed, 28 May 2025 06:22:56 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C9EAD206788C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1748438576; bh=zeu2XDixgwuEHRFp0qtPdbmePaB4mB2THj2/mK+wACo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cKaRoHUQp0yd8UWg5dotIiSINBmqRA0jutVClqZlUwFccRosBhNKddhhya+kWCYvJ vHQpbvPVaLkcFEnNn/5kBnk7aKUw870TWfSgGb0eBSvlnt83T1qEmzFRA7007zqv35 2maKrxzMrrI7B3X3gHiJPQ1NlmPiXn6LXnM3StGU= From: Andre Muezerie To: andremue@linux.microsoft.com Cc: dev@dpdk.org, hkalra@marvell.com, kirankumark@marvell.com, ndabilpuram@marvell.com, skori@marvell.com, skoteshwar@marvell.com Subject: [PATCH v3] drivers: remove __rte_used from functions for compatibility with MSVC Date: Wed, 28 May 2025 06:22:51 -0700 Message-Id: <1748438571-20477-1-git-send-email-andremue@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1743731269-5936-1-git-send-email-andremue@linux.microsoft.com> References: <1743731269-5936-1-git-send-email-andremue@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org With gcc, the macro __rte_used translates to __attribute__((used)). MSVC has something to the same effect, but harder to use and with some limitations (one being that it cannot be used with "static"). Therefore, it makes sense to avoid __rte_used in some cases. The functions modified in this patch don't really need to use __rte_used. Instead, these functions can be involved in same ifdefs used in the callers. That way, they are only defined when needed (when someone is actually calling the function). Doing so makes the code compatible with MSVC and avoids compiler warnings about functions being defined but not used. Signed-off-by: Andre Muezerie Acked-by: Pavan Nikhilesh --- drivers/net/cnxk/cn10k_rx_select.c | 4 +++- drivers/net/cnxk/cn10k_tx_select.c | 4 +++- drivers/net/cnxk/cn20k_rx_select.c | 4 +++- drivers/net/cnxk/cn20k_tx_select.c | 4 +++- drivers/net/cnxk/cn9k_rx_select.c | 4 +++- drivers/net/cnxk/cn9k_tx_select.c | 4 +++- 6 files changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/net/cnxk/cn10k_rx_select.c b/drivers/net/cnxk/cn10k_rx_select.c index fe1f0dda73..5258d7f745 100644 --- a/drivers/net/cnxk/cn10k_rx_select.c +++ b/drivers/net/cnxk/cn10k_rx_select.c @@ -5,7 +5,8 @@ #include "cn10k_ethdev.h" #include "cn10k_rx.h" -static __rte_used void +#if defined(RTE_ARCH_ARM64) && !defined(CNXK_DIS_TMPLT_FUNC) +static void pick_rx_func(struct rte_eth_dev *eth_dev, const eth_rx_burst_t rx_burst[NIX_RX_OFFLOAD_MAX]) { @@ -21,6 +22,7 @@ pick_rx_func(struct rte_eth_dev *eth_dev, rte_atomic_thread_fence(rte_memory_order_release); } +#endif static uint16_t __rte_noinline __rte_hot __rte_unused cn10k_nix_flush_rx(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t pkts) diff --git a/drivers/net/cnxk/cn10k_tx_select.c b/drivers/net/cnxk/cn10k_tx_select.c index 56fddac5a0..066c65c9b9 100644 --- a/drivers/net/cnxk/cn10k_tx_select.c +++ b/drivers/net/cnxk/cn10k_tx_select.c @@ -5,7 +5,8 @@ #include "cn10k_ethdev.h" #include "cn10k_tx.h" -static __rte_used inline void +#if defined(RTE_ARCH_ARM64) && !defined(CNXK_DIS_TMPLT_FUNC) +static inline void pick_tx_func(struct rte_eth_dev *eth_dev, const eth_tx_burst_t tx_burst[NIX_TX_OFFLOAD_MAX]) { @@ -19,6 +20,7 @@ pick_tx_func(struct rte_eth_dev *eth_dev, rte_eth_fp_ops[eth_dev->data->port_id].tx_pkt_burst = eth_dev->tx_pkt_burst; } +#endif #if defined(RTE_ARCH_ARM64) static int diff --git a/drivers/net/cnxk/cn20k_rx_select.c b/drivers/net/cnxk/cn20k_rx_select.c index 25c79434cd..d60f4e62f7 100644 --- a/drivers/net/cnxk/cn20k_rx_select.c +++ b/drivers/net/cnxk/cn20k_rx_select.c @@ -5,7 +5,8 @@ #include "cn20k_ethdev.h" #include "cn20k_rx.h" -static __rte_used void +#if defined(RTE_ARCH_ARM64) && !defined(CNXK_DIS_TMPLT_FUNC) +static void pick_rx_func(struct rte_eth_dev *eth_dev, const eth_rx_burst_t rx_burst[NIX_RX_OFFLOAD_MAX]) { struct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev); @@ -18,6 +19,7 @@ pick_rx_func(struct rte_eth_dev *eth_dev, const eth_rx_burst_t rx_burst[NIX_RX_O rte_atomic_thread_fence(rte_memory_order_release); } +#endif static uint16_t __rte_noinline __rte_hot __rte_unused cn20k_nix_flush_rx(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t pkts) diff --git a/drivers/net/cnxk/cn20k_tx_select.c b/drivers/net/cnxk/cn20k_tx_select.c index fb62b54a5f..95cd1148a1 100644 --- a/drivers/net/cnxk/cn20k_tx_select.c +++ b/drivers/net/cnxk/cn20k_tx_select.c @@ -5,7 +5,8 @@ #include "cn20k_ethdev.h" #include "cn20k_tx.h" -static __rte_used inline void +#if defined(RTE_ARCH_ARM64) && !defined(CNXK_DIS_TMPLT_FUNC) +static inline void pick_tx_func(struct rte_eth_dev *eth_dev, const eth_tx_burst_t tx_burst[NIX_TX_OFFLOAD_MAX]) { struct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev); @@ -16,6 +17,7 @@ pick_tx_func(struct rte_eth_dev *eth_dev, const eth_tx_burst_t tx_burst[NIX_TX_O if (eth_dev->data->dev_started) rte_eth_fp_ops[eth_dev->data->port_id].tx_pkt_burst = eth_dev->tx_pkt_burst; } +#endif #if defined(RTE_ARCH_ARM64) static int diff --git a/drivers/net/cnxk/cn9k_rx_select.c b/drivers/net/cnxk/cn9k_rx_select.c index 0d4031ddeb..bb943e694d 100644 --- a/drivers/net/cnxk/cn9k_rx_select.c +++ b/drivers/net/cnxk/cn9k_rx_select.c @@ -5,7 +5,8 @@ #include "cn9k_ethdev.h" #include "cn9k_rx.h" -static __rte_used void +#if defined(RTE_ARCH_ARM64) && !defined(CNXK_DIS_TMPLT_FUNC) +static void pick_rx_func(struct rte_eth_dev *eth_dev, const eth_rx_burst_t rx_burst[NIX_RX_OFFLOAD_MAX]) { @@ -19,6 +20,7 @@ pick_rx_func(struct rte_eth_dev *eth_dev, rte_eth_fp_ops[eth_dev->data->port_id].rx_pkt_burst = eth_dev->rx_pkt_burst; } +#endif #if defined(RTE_ARCH_ARM64) static void diff --git a/drivers/net/cnxk/cn9k_tx_select.c b/drivers/net/cnxk/cn9k_tx_select.c index 497449b1c4..784faa3b8b 100644 --- a/drivers/net/cnxk/cn9k_tx_select.c +++ b/drivers/net/cnxk/cn9k_tx_select.c @@ -5,7 +5,8 @@ #include "cn9k_ethdev.h" #include "cn9k_tx.h" -static __rte_used void +#if defined(RTE_ARCH_ARM64) && !defined(CNXK_DIS_TMPLT_FUNC) +static void pick_tx_func(struct rte_eth_dev *eth_dev, const eth_tx_burst_t tx_burst[NIX_TX_OFFLOAD_MAX]) { @@ -19,6 +20,7 @@ pick_tx_func(struct rte_eth_dev *eth_dev, rte_eth_fp_ops[eth_dev->data->port_id].tx_pkt_burst = eth_dev->tx_pkt_burst; } +#endif #if defined(RTE_ARCH_ARM64) static int -- 2.49.0.vfs.0.3