From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4CC3446837; Sat, 31 May 2025 02:22:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 366DC4025E; Sat, 31 May 2025 02:22:05 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 2BED24025A for ; Sat, 31 May 2025 02:22:04 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1213) id 480E32078627; Fri, 30 May 2025 17:22:03 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 480E32078627 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1748650923; bh=SumKkx7izRAQUPITafRm/SVDVz2/LecVw7eqYzJrx2Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gyLFkHrDUzE+cDWZYkGvAcYSG/7Vya8IO2SZotJsDoKTIgnZxeC/Rg+nDZJQpZsKI eRmA28FCXPp+yDlC7IulCJq8VacBgz03JAEte/MZ4/LC9GjNagPpl6+MOA3dEF0CDw bJXRmcTSZytgvXS5CsPlLJls2At1nfL8bFUKMQFg= From: Andre Muezerie To: andremue@linux.microsoft.com Cc: bingz@nvidia.com, dev@dpdk.org, dsosnowski@nvidia.com, matan@nvidia.com, orika@nvidia.com, suanmingm@nvidia.com, viacheslavo@nvidia.com, mkashani@nvidia.com Subject: [PATCH v2] net/mlx5: declare size of rte_v128u32_t Date: Fri, 30 May 2025 17:21:57 -0700 Message-Id: <1748650917-31700-1-git-send-email-andremue@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1746457823-11135-1-git-send-email-andremue@linux.microsoft.com> References: <1746457823-11135-1-git-send-email-andremue@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When compiling with MSVC the error below is hit: drivers\net\mlx5\mlx5_tx.h(1148): error C2065: 'rte_v128u32_t': undeclared identifier Turns out that with MSVC the data type rte_v128u32_t is not used, but its size needs to be known. This patch defines a macro to store that size and replaces instances of sizeof(rte_v128u32_t) with that macro. A static assert is added to ensure the new macro never diverges from sizeof(rte_v128u32_t). Signed-off-by: Andre Muezerie --- drivers/net/mlx5/mlx5_defs.h | 2 ++ drivers/net/mlx5/mlx5_rxtx.c | 11 ++++++++--- drivers/net/mlx5/mlx5_tx.h | 2 +- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h index 9c454983be..c5e2c59309 100644 --- a/drivers/net/mlx5/mlx5_defs.h +++ b/drivers/net/mlx5/mlx5_defs.h @@ -196,4 +196,6 @@ #define MLX5_CNT_SVC_CYCLE_TIME_DEFAULT 500 +#define MLX5_SIZEOF_V128U32_T 16 + #endif /* RTE_PMD_MLX5_DEFS_H_ */ diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index 9c075f6a56..3f4942e225 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxtx.c @@ -28,11 +28,16 @@ #include "mlx5_tx.h" /* static asserts */ +#ifndef RTE_TOOLCHAIN_MSVC +static_assert(sizeof(rte_v128u32_t) == MLX5_SIZEOF_V128U32_T, + "MLX5_SIZEOF_V128U32_T must hold sizeof(rte_v128u32_t)"); +#endif + static_assert(MLX5_CQE_STATUS_HW_OWN < 0, "Must be negative value"); static_assert(MLX5_CQE_STATUS_SW_OWN < 0, "Must be negative value"); static_assert(MLX5_ESEG_MIN_INLINE_SIZE == (sizeof(uint16_t) + - sizeof(rte_v128u32_t)), + MLX5_SIZEOF_V128U32_T), "invalid Ethernet Segment data size"); static_assert(MLX5_ESEG_MIN_INLINE_SIZE == (sizeof(uint16_t) + @@ -41,7 +46,7 @@ static_assert(MLX5_ESEG_MIN_INLINE_SIZE == "invalid Ethernet Segment data size"); static_assert(MLX5_ESEG_MIN_INLINE_SIZE == (sizeof(uint16_t) + - sizeof(rte_v128u32_t)), + MLX5_SIZEOF_V128U32_T), "invalid Ethernet Segment data size"); static_assert(MLX5_ESEG_MIN_INLINE_SIZE == (sizeof(uint16_t) + @@ -50,7 +55,7 @@ static_assert(MLX5_ESEG_MIN_INLINE_SIZE == "invalid Ethernet Segment data size"); static_assert(MLX5_ESEG_MIN_INLINE_SIZE == (sizeof(uint16_t) + - sizeof(rte_v128u32_t)), + MLX5_SIZEOF_V128U32_T), "invalid Ethernet Segment data size"); static_assert(MLX5_ESEG_MIN_INLINE_SIZE == (sizeof(uint16_t) + diff --git a/drivers/net/mlx5/mlx5_tx.h b/drivers/net/mlx5/mlx5_tx.h index 55568c41b1..5647f6a37d 100644 --- a/drivers/net/mlx5/mlx5_tx.h +++ b/drivers/net/mlx5/mlx5_tx.h @@ -1145,7 +1145,7 @@ mlx5_tx_eseg_data(struct mlx5_txq_data *__rte_restrict txq, } else { /* Fill the gap in the title WQEBB with inline data. */ rte_mov16(pdst, psrc); - psrc += sizeof(rte_v128u32_t); + psrc += MLX5_SIZEOF_V128U32_T; } pdst = (uint8_t *)(es + 2); MLX5_ASSERT(inlen >= MLX5_ESEG_MIN_INLINE_SIZE); -- 2.49.0.vfs.0.3