From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 66306AAB5 for ; Wed, 11 Jul 2018 10:11:01 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 534422C2; Wed, 11 Jul 2018 04:10:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 11 Jul 2018 04:10:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=CxY7B3IwjeNhOkN1qcyYjEWj8q 2BwjuWYZrlHjEnamI=; b=Ol7xFNrJlzR5EA7TXCMQAn02eZNgzaApy1xXa66Ul0 C/dW9cbpqEwi8cWmwwX/0GAscqG6GSIa8Op3c8v8MaW1SlwgR7KCQy6LJ2oVoDCJ hzREPZJ9z8E3F3rCRw5Do7grf9sO7sJ/HTYesSEAvx9VyJ6rPOkhcsj7jLf9wxAC o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=CxY7B3 IwjeNhOkN1qcyYjEWj8q2BwjuWYZrlHjEnamI=; b=r6GmU4qXU3PivM0cJXjXt3 vMLQA20X1kbJt2yYl40t2VaoroHj/52qi0r/q3sHGvFX0fv9qL5pWJ7zR5p8U0yP vJL38O0xf8MF7cyrYa5/ItQQohdUep9Znm7sMP/7KktT3YhmETUnl29nMQ9NV3fH ZUMl6EhBfYPQxyeJbMWM3+Yn3t1oqHPFmPqfFbdaODKQjWqcxjO3JehP5cJKqcpI qdOPpJl+WfaaAiufYX37HMIWLGkoOBOQQ9rYmz/AX+R/tGZvQGQ4Poeu17pwc1JA EEcYY7ckZTRgSChfBjH05atgfdZpHWcJ25YRXimvcCLz8GK4S2Bb/a+mfmIQ0jrw == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4E325E4072; Wed, 11 Jul 2018 04:10:57 -0400 (EDT) From: Thomas Monjalon To: Gaetan Rivet Cc: dev@dpdk.org Date: Wed, 11 Jul 2018 10:10:55 +0200 Message-ID: <1749487.M6D8NYWNUp@xps> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v10 06/27] eal: introduce device class abstraction X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jul 2018 08:11:01 -0000 05/07/2018 13:48, Gaetan Rivet: > +/** > + * @file > + * > + * DPDK device class interface. > + * > + * This file exposes API and interfaces of device classes. What is the difference between "API" and "interfaces"? I think you need to explain what is a device class. You can mention examples ethdev and cryptodev. > +#define RTE_REGISTER_CLASS(nm, cls) \ > +RTE_INIT_PRIO(classinitfn_ ##nm, CLASS); \ If you remove the ; you can avoid next line. See this patch which removes such useless line: https://patches.dpdk.org/patch/41228/ > +static void classinitfn_ ##nm(void) \ > +{\ > + (cls).name = RTE_STR(nm);\ Better to insert a space before \ > + rte_class_register(&cls); \ > +}