From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id B51D51BB40 for <dev@dpdk.org>; Fri, 19 Apr 2019 13:50:27 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3487626D0D; Fri, 19 Apr 2019 07:50:27 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 19 Apr 2019 07:50:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=216SRpt1gJPij3m5oWh6z2DQ2ECFNv6oGLzZeOc+EIU=; b=ZjRIUJlRVMJ7 1mRUPjc9JyDjcDRuIseK2w+MgFildt/K+vc6gxsZlK18gkOVips745FyCMyiOjrt ISXUyJm26Z7bJa0yP8/FzbVuybeMi4v0oq5v9O2ml9RXlTXNVqGS08S4WEuu+KzX 0B8dXDIySGkmGURVlXXxLXsZANRpSvI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=216SRpt1gJPij3m5oWh6z2DQ2ECFNv6oGLzZeOc+E IU=; b=6lTL5uaLxLoT8ZPkAIZk5ygECazYRYE4tD2XKEF5tHfXBizrWW4nK1Lng lTZ5dHutnVKxBiAGsPW8J8ef7JSiFR4J6i+UTRjG/AlXgLwBgIYupuBoFp5b2o+b OL3xGz1dIUohpIzTknbSqQmA1PTBCVA/3ag3ltMV5fLLpa2XAlvdiudBpXUcUWgf 6r8rAl3qIw33e5qOnQmXhmBV4thVDInzmDPwqgxNew0yUZBfT9VYBeOhQAYQepM2 dMyheoDSDzw61cmMwSubAJom6lSif+iihhW0WanXv2M96SmLI7l0jBr0o9OwtKox 4cSJCRYuRlheCU6ISSNZI65b/NRYg== X-ME-Sender: <xms:Ara5XP3RUQEKziIpZTsVL7inRATtPSbpxqq4-vj9fUmksXwHxhPpIg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeejgdegfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: <xmx:Ara5XA5ifJmtaArGswQqh36GagQjQ-N4Llc1JOOusOMCYzcC_cj_vA> <xmx:Ara5XCpdaeS6Rxtq-LOK3PFnj42d_Z_nCydODffKo7tXQbARgRYpew> <xmx:Ara5XIWWDWd3uhyOlpgtVuUUGlyoIwP_8tW3S-TuVCka7F5fTALZ0Q> <xmx:A7a5XFAN_Ar7gN5LyMiMxH9Lq7XA6VmtQEQ3CSqGKJVnLKuelDarqg> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3BC9D103C9; Fri, 19 Apr 2019 07:50:25 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: "Jozwiak, TomaszX" <tomaszx.jozwiak@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "Richardson, Bruce" <bruce.richardson@intel.com>, "david.marchand@redhat.com" <david.marchand@redhat.com>, "Trahe, Fiona" <fiona.trahe@intel.com>, "yskoh@mellanox.com" <yskoh@mellanox.com>, "Cel, TomaszX" <tomaszx.cel@intel.com> Date: Fri, 19 Apr 2019 13:50:23 +0200 Message-ID: <1749599.B640tvC1p7@xps> In-Reply-To: <CA70B6012E3ADB4184D44E025E5FF01B6A20B909@LCSMSX155.ger.corp.intel.com> References: <1555667827-3715-1-git-send-email-tomaszx.jozwiak@intel.com> <3955282.IgHOaonqCx@xps> <CA70B6012E3ADB4184D44E025E5FF01B6A20B909@LCSMSX155.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 19 Apr 2019 11:50:28 -0000 Please stop top-posting, and read again below: 19/04/2019 13:36, Jozwiak, TomaszX: > test_deflate_comp_decomp function is common for all test cases. > The options for this function are inside struct interim_data_params, > which is passed to test_deflate_comp_decomp function as a pointer. > > The field buf_idx should be initialized because is used inside test_deflate_comp_decomp > That's the reason of: > int_data.buf_idx = &i; > > I'm not an author of this solution - sorry. > > We can review this and try to add new solution. I am not talking about int_data but the use of "i". Please look again your patch, you are using "j" instead of "i" and "i" is kept alone. Moreover I don't know how the pointer of a local variable can be used. > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 19/04/2019 12:57, Jozwiak, TomaszX: > > > > What is supposed to be "i"? > > > > It is initialized at 0 and never touched. > > > > > > > It's touched inside test_deflate_comp_decomp function. > > > > What do you mean? > > It's a local variable and its address is referenced: > > int_data.buf_idx = &i; > > It looks really wrong. > > > > Another error is seen in FreeBSD. > > > > Should I totally revert this patch? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 16C97A00E6 for <public@inbox.dpdk.org>; Fri, 19 Apr 2019 13:50:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A95301BB9D; Fri, 19 Apr 2019 13:50:29 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id B51D51BB40 for <dev@dpdk.org>; Fri, 19 Apr 2019 13:50:27 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3487626D0D; Fri, 19 Apr 2019 07:50:27 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 19 Apr 2019 07:50:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=216SRpt1gJPij3m5oWh6z2DQ2ECFNv6oGLzZeOc+EIU=; b=ZjRIUJlRVMJ7 1mRUPjc9JyDjcDRuIseK2w+MgFildt/K+vc6gxsZlK18gkOVips745FyCMyiOjrt ISXUyJm26Z7bJa0yP8/FzbVuybeMi4v0oq5v9O2ml9RXlTXNVqGS08S4WEuu+KzX 0B8dXDIySGkmGURVlXXxLXsZANRpSvI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=216SRpt1gJPij3m5oWh6z2DQ2ECFNv6oGLzZeOc+E IU=; b=6lTL5uaLxLoT8ZPkAIZk5ygECazYRYE4tD2XKEF5tHfXBizrWW4nK1Lng lTZ5dHutnVKxBiAGsPW8J8ef7JSiFR4J6i+UTRjG/AlXgLwBgIYupuBoFp5b2o+b OL3xGz1dIUohpIzTknbSqQmA1PTBCVA/3ag3ltMV5fLLpa2XAlvdiudBpXUcUWgf 6r8rAl3qIw33e5qOnQmXhmBV4thVDInzmDPwqgxNew0yUZBfT9VYBeOhQAYQepM2 dMyheoDSDzw61cmMwSubAJom6lSif+iihhW0WanXv2M96SmLI7l0jBr0o9OwtKox 4cSJCRYuRlheCU6ISSNZI65b/NRYg== X-ME-Sender: <xms:Ara5XP3RUQEKziIpZTsVL7inRATtPSbpxqq4-vj9fUmksXwHxhPpIg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeejgdegfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: <xmx:Ara5XA5ifJmtaArGswQqh36GagQjQ-N4Llc1JOOusOMCYzcC_cj_vA> <xmx:Ara5XCpdaeS6Rxtq-LOK3PFnj42d_Z_nCydODffKo7tXQbARgRYpew> <xmx:Ara5XIWWDWd3uhyOlpgtVuUUGlyoIwP_8tW3S-TuVCka7F5fTALZ0Q> <xmx:A7a5XFAN_Ar7gN5LyMiMxH9Lq7XA6VmtQEQ3CSqGKJVnLKuelDarqg> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3BC9D103C9; Fri, 19 Apr 2019 07:50:25 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: "Jozwiak, TomaszX" <tomaszx.jozwiak@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "Richardson, Bruce" <bruce.richardson@intel.com>, "david.marchand@redhat.com" <david.marchand@redhat.com>, "Trahe, Fiona" <fiona.trahe@intel.com>, "yskoh@mellanox.com" <yskoh@mellanox.com>, "Cel, TomaszX" <tomaszx.cel@intel.com> Date: Fri, 19 Apr 2019 13:50:23 +0200 Message-ID: <1749599.B640tvC1p7@xps> In-Reply-To: <CA70B6012E3ADB4184D44E025E5FF01B6A20B909@LCSMSX155.ger.corp.intel.com> References: <1555667827-3715-1-git-send-email-tomaszx.jozwiak@intel.com> <3955282.IgHOaonqCx@xps> <CA70B6012E3ADB4184D44E025E5FF01B6A20B909@LCSMSX155.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190419115023.UA7IOEyi-YO6hUuTd6T3Hy7bpYDu9uS_IqkOV_8hSF4@z> Please stop top-posting, and read again below: 19/04/2019 13:36, Jozwiak, TomaszX: > test_deflate_comp_decomp function is common for all test cases. > The options for this function are inside struct interim_data_params, > which is passed to test_deflate_comp_decomp function as a pointer. > > The field buf_idx should be initialized because is used inside test_deflate_comp_decomp > That's the reason of: > int_data.buf_idx = &i; > > I'm not an author of this solution - sorry. > > We can review this and try to add new solution. I am not talking about int_data but the use of "i". Please look again your patch, you are using "j" instead of "i" and "i" is kept alone. Moreover I don't know how the pointer of a local variable can be used. > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 19/04/2019 12:57, Jozwiak, TomaszX: > > > > What is supposed to be "i"? > > > > It is initialized at 0 and never touched. > > > > > > > It's touched inside test_deflate_comp_decomp function. > > > > What do you mean? > > It's a local variable and its address is referenced: > > int_data.buf_idx = &i; > > It looks really wrong. > > > > Another error is seen in FreeBSD. > > > > Should I totally revert this patch?