From: Andre Muezerie <andremue@linux.microsoft.com>
To: andremue@linux.microsoft.com
Cc: bruce.richardson@intel.com, dev@dpdk.org
Subject: [PATCH v2] buildtools: allow a different minimum meson version for Windows
Date: Mon, 16 Jun 2025 08:31:11 -0700 [thread overview]
Message-ID: <1750087871-27179-1-git-send-email-andremue@linux.microsoft.com> (raw)
In-Reply-To: <1749831278-8286-1-git-send-email-andremue@linux.microsoft.com>
There is a minimum meson version specified in the DPDK meson project
section, which has been documented. This string is parsed by
buildtools\get-min-meson-version.py and this information is used by
lab automation to install the corresponding meson package on the
build machine.
Turns out that the meson version specified on the DPDK project
(0.57.x) is buggy on Windows: it has issues related to path
manipulation, and these issues are causing failures. Therefore,
a newer meson is required on Windows.
To avoid bringing the minimum requirements up for all operating
systems before a more appropriate release, this patch implements
a mechanism allowing a different version to be specified for Windows.
Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
buildtools/get-min-meson-version.py | 8 ++++++--
meson.build | 1 +
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/buildtools/get-min-meson-version.py b/buildtools/get-min-meson-version.py
index f0de8fdf2b..3769f3da73 100755
--- a/buildtools/get-min-meson-version.py
+++ b/buildtools/get-min-meson-version.py
@@ -11,12 +11,15 @@
basedir = dirname(buildtools_path)
with open(join(basedir, "meson.build")) as f:
+ keyword = "meson_version_windows" if os.name == "nt" else "meson_version"
+ pattern = fr"{keyword}:\s*'>=\s*([0-9\.]+)'"
+
for ln in f.readlines():
- if "meson_version" not in ln:
+ if keyword not in ln:
continue
ln = ln.strip()
- ver_match = re.search(r"meson_version:\s*'>=\s*([0-9\.]+)'", ln)
+ ver_match = re.search(pattern, ln)
if not ver_match:
print(
f"Meson version specifier not in recognised format: '{ln}'",
@@ -24,3 +27,4 @@
)
sys.exit(1)
print(ver_match.group(1), end="")
+ break
diff --git a/meson.build b/meson.build
index 5ff68cb3af..2423884df7 100644
--- a/meson.build
+++ b/meson.build
@@ -11,6 +11,7 @@ project('DPDK', 'c',
'warning_level=2',
],
meson_version: '>= 0.57.2'
+ # meson_version_windows: '>= 1.5.2'
)
fs = import('fs')
--
2.49.0.vfs.0.3
next prev parent reply other threads:[~2025-06-16 15:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 16:14 [PATCH] " Andre Muezerie
2025-06-16 7:36 ` Bruce Richardson
2025-06-16 8:27 ` Bruce Richardson
2025-06-16 15:09 ` Andre Muezerie
2025-06-16 15:16 ` Bruce Richardson
2025-06-16 15:31 ` Andre Muezerie [this message]
2025-06-16 15:38 ` [PATCH v2] " Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1750087871-27179-1-git-send-email-andremue@linux.microsoft.com \
--to=andremue@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).