From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7563454DF; Mon, 24 Jun 2024 12:06:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8CA0540E64; Mon, 24 Jun 2024 12:06:42 +0200 (CEST) Received: from fout1-smtp.messagingengine.com (fout1-smtp.messagingengine.com [103.168.172.144]) by mails.dpdk.org (Postfix) with ESMTP id 9FD4040DDD for ; Mon, 24 Jun 2024 12:05:59 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.nyi.internal (Postfix) with ESMTP id 1EFCC138024E; Mon, 24 Jun 2024 06:05:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 24 Jun 2024 06:05:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1719223559; x=1719309959; bh=yb9wOU3XU/noSG/i0oLf6siNi9WB9Oxv+iVB/RyGPKs=; b= B0YH7tnk9P1NjadH/OH91nU9wf/Emf7Lyi0xr2rxItNIO9/B0960nGI3r/M2DK/s ZrnhXleeTUSm622RWs+U3SiAZ0qO4thcxmp2MwA3xRisjhm5ZJyaeQ99fJEtXf7a gK2aGsi5QGmGyhCFtNuDlGO1b8lW8xU+sUU0eNnW1QO2X05gsFBA+85dHwC06BYt p0+BiSESeTqu4GBM8eiVuD4Uh9phjqBS0d5K2owKYIbWWuiHN1EF+6tVawyDRwg/ OGfqjPRe1yOQn6IsV3JdCgc9njePYft7zIfPzOnzM+GbjbuHjRQxXzDWgrn3bZJX PCncDf80KpBwLnWRqkN5vA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1719223559; x= 1719309959; bh=yb9wOU3XU/noSG/i0oLf6siNi9WB9Oxv+iVB/RyGPKs=; b=B byTP6xYhTmqLlaC9OKxK612N3YLZNgOkOGXYDhaqzJ6ad+/4xEm/Wl7W1/GK75PM vZegHTx+nL3Xo9h3+3DFINBS4TpeLn9B++NZpwPwYCEO9eIMtgKwiAlSSQl61veA Cy/eOMV/tLumAnD3fM8wupf/XuiudWxhPM77knFsOs5u706uUF1hugdBc5GaLHX9 bn6nBEv+Rkb6SDSXqa2n617KN9emLKt3SS1oLQcP2kSUNV8zTlXrOenAIZP6AwDE ix/TDM00LPzZEA8GcXLFtZyr3SdOOVIu8/CesS+sVUakHYXLRqbwKu2Z5ONKvJTL DqxxirdutrRhme9ffPVxg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeeguddgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedtheevtdekiedvueeuvdei uddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 24 Jun 2024 06:05:56 -0400 (EDT) From: Thomas Monjalon To: Mattias =?ISO-8859-1?Q?R=F6nnblom?= Cc: dev@dpdk.org, hofors@lysator.liu.se, Morten =?ISO-8859-1?Q?Br=F8rup?= , Stephen Hemminger , Abdullah Sevincer , Pavan Nikhilesh , David Hunt , Vladimir Medvedkin , Bruce Richardson , anatoly.burakov@intel.com, david.marchand@redhat.com, maxime.coquelin@redhat.com Subject: Re: [PATCH v4 13/13] eal: provide option to use compiler memcpy instead of RTE Date: Mon, 24 Jun 2024 12:05:53 +0200 Message-ID: <1751466.UtaOMtURT2@thomas> In-Reply-To: <20240620175731.420639-14-mattias.ronnblom@ericsson.com> References: <20240620115027.420304-2-mattias.ronnblom@ericsson.com> <20240620175731.420639-1-mattias.ronnblom@ericsson.com> <20240620175731.420639-14-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 20/06/2024 19:57, Mattias R=C3=B6nnblom: > Provide build option to have functions in delegate to > the standard compiler/libc memcpy(), instead of using the various > custom DPDK, handcrafted, per-architecture rte_memcpy() > implementations. >=20 > A new meson build option 'use_cc_memcpy' is added. By default, > the compiler/libc memcpy() is used. >=20 > The performance benefits of the custom DPDK rte_memcpy() > implementations have been diminishing with every compiler release, and > with current toolchains the use of a custom memcpy() implementation > may even be a liability. >=20 > This patch leaves an option to stay on the custom DPDK implementations, > would that prove beneficial for certain applications or architectures. [...] > --- a/meson_options.txt > +++ b/meson_options.txt > +option('use_cc_memcpy', type: 'boolean', value: true, description: > + 'Have the functions of delegate to compiler/libc m= emcpy() instead of using custom implementation.') I suppose you propose this change for 24.11? I would prefer getting the option disabled in 24.07, so we can run tests during months before enabling it by default. This period would also help to make sure it is compiling in all cases. Please could you enable the option in our compilation scripts?